Re: Issues upgrading to Wicket 8.0.0-M9

2018-02-20 Thread Sebastien Briquet
Right, latest jQuery-ui release is September 14, 2016 :(

On Tue, Feb 20, 2018 at 1:04 PM, Emond Papegaaij  wrote:

> On maandag 19 februari 2018 11:22:30 CET Thomas Heigl wrote:
> > 1. Current WiQuery version is not compatible with M9
> >
> > It still depends on WicketEventJQueryResourceReference. It would be
> great
> > if someone could cut a milestone release for WiQuery as well, so I can do
> > further testing with my application.
>
> I've just pushed a fix for this. WiQuery master now compiles against M9.
> Please
> not that wiquery-jquery-ui is hopelessly outdated. I hope to get that
> fixed in
> the comming month. However, it seems jquery-ui is dead as well (which does
> make it easier to stay up to date from now on :) ).
>
> Best regards,
> Emond
>
>
>
> -
> To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
> For additional commands, e-mail: users-h...@wicket.apache.org
>
>


Re: Issues upgrading to Wicket 8.0.0-M9

2018-02-20 Thread Emond Papegaaij
On maandag 19 februari 2018 11:22:30 CET Thomas Heigl wrote:
> 1. Current WiQuery version is not compatible with M9
> 
> It still depends on WicketEventJQueryResourceReference. It would be great
> if someone could cut a milestone release for WiQuery as well, so I can do
> further testing with my application.

I've just pushed a fix for this. WiQuery master now compiles against M9. Please 
not that wiquery-jquery-ui is hopelessly outdated. I hope to get that fixed in 
the comming month. However, it seems jquery-ui is dead as well (which does 
make it easier to stay up to date from now on :) ).

Best regards,
Emond



-
To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org
For additional commands, e-mail: users-h...@wicket.apache.org



Re: Issues upgrading to Wicket 8.0.0-M9

2018-02-19 Thread Thomas Heigl
Thanks a lot Sven!

Thomas

On Mon, Feb 19, 2018 at 12:42 PM, Sven Meier  wrote:

> No need for a quickstart for 2)… I've found the culprit.
>
> Will be fixed immediately.
>
> Thanks
> Sven
>
> ⁣Gesendet mit Blue ​
>
> Am 19. Feb. 2018, 12:23, um 12:23, Sven Meier  schrieb:
> >Hi,
> >
> >many thanks for following our milestones closely.
> >
> >Could you please provide a quickstart for 2)?
> >
> >Regarding 3): Alternative would be calling beforeRender() instead. I'm
> >not sure whether that will work for you though, without understanding
> >why you called that internal API at all.
> >
> >Best regards
> >Sven
> >
> >⁣Gesendet mit Blue ​
> >
> >Am 19. Feb. 2018, 11:22, um 11:22, Thomas Heigl 
> >schrieb:
> >>Hi all,
> >>
> >>I upgraded my application from M8 to M9 yesterday and encountered 3
> >>issues:
> >>
> >>1. Current WiQuery version is not compatible with M9
> >>
> >>It still depends on WicketEventJQueryResourceReference. It would be
> >>great
> >>if someone could cut a milestone release for WiQuery as well, so I can
> >>do
> >>further testing with my application.
> >>
> >>2. Failing tests for components with AjaxLazyLoadPanel
> >>
> >>It seems that it is not possible anymore, to load an AjaxLazyLoadPanel
> >>during an Ajax request. I have a panel that is initially invisible and
> >>shown via an Ajax toggle link that contains a AjaxLazyLoadPanel. My
> >>test
> >>fails with:
> >>
> >>java.lang.IllegalStateException: Components can no  longer be added
> >>> at
> >>>
> >>org.apache.wicket.page.PartialPageUpdate.assertNotFrozen(
> PartialPageUpdate.java:854)
> >>> at
> >>>
> >>org.apache.wicket.page.PartialPageUpdate.assertComponentsNotFrozen(
> PartialPageUpdate.java:847)
> >>> at
> >>org.apache.wicket.page.PartialPageUpdate.add(PartialPageUpdate.java:444)
> >>> at
> >>>
> >>org.apache.wicket.ajax.AjaxRequestHandler.add(
> AjaxRequestHandler.java:263)
> >>> at
> >>>
> >>org.apache.wicket.ajax.AjaxRequestHandler.add(
> AjaxRequestHandler.java:239)
> >>> at
> >>>
> >>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.lambda$
> isLoaded$1(AjaxLazyLoadPanel.java:258)
> >>> at java.util.Optional.ifPresent(Optional.java:159)
> >>> at
> >>>
> >>org.apache.wicket.extensions.ajax.markup.html.
> AjaxLazyLoadPanel.isLoaded(AjaxLazyLoadPanel.java:258)
> >>> at
> >>>
> >>org.apache.wicket.extensions.ajax.markup.html.
> AjaxLazyLoadPanel.onConfigure(AjaxLazyLoadPanel.java:212)
> >>
> >>
> >>The toggle link sets the panel containing the lazy-load panel visible
> >>and
> >>adds it to the ajax target:
> >>
> >>public void onClick(AjaxRequestTarget target) {
> >>> component.setVisible(!component.isVisible());
> >>> target.add(component);
> >>> }
> >>
> >>
> >>3. Removed (internal) APIs
> >>
> >>I have a custom component for rendering an infinite-scrolling list
> >that
> >>uses two (internal) methods to update the underlying DataView:
> >>
> >>public void onClick(AjaxRequestTarget target) {
> >>> pageable.setItemsPerPage(pageable.getItemsPerPage() +
> >>> additionalItems);
> >>
> >>view.prepareForRender();
> >>> view.afterRender();
> >>
> >>}
> >>
> >>
> >>Both `prepareForRender` and `afterRender` are no longer accessible.
> >>Does
> >>anyone have a suggestion what I could call instead? I sadly do not
> >>remember
> >>why exactly we work against Wicket's default rendering in that case
> >but
> >>it
> >>looks like we want to do everything *except* the actual render.
> >>
> >>Best regards,
> >>
> >>Thomas
>


Re: Issues upgrading to Wicket 8.0.0-M9

2018-02-19 Thread Sven Meier
No need for a quickstart for 2)… I've found the culprit.

Will be fixed immediately.

Thanks
Sven

⁣Gesendet mit Blue ​

Am 19. Feb. 2018, 12:23, um 12:23, Sven Meier  schrieb:
>Hi,
>
>many thanks for following our milestones closely.
>
>Could you please provide a quickstart for 2)?
>
>Regarding 3): Alternative would be calling beforeRender() instead. I'm
>not sure whether that will work for you though, without understanding
>why you called that internal API at all.
>
>Best regards
>Sven
>
>⁣Gesendet mit Blue ​
>
>Am 19. Feb. 2018, 11:22, um 11:22, Thomas Heigl 
>schrieb:
>>Hi all,
>>
>>I upgraded my application from M8 to M9 yesterday and encountered 3
>>issues:
>>
>>1. Current WiQuery version is not compatible with M9
>>
>>It still depends on WicketEventJQueryResourceReference. It would be
>>great
>>if someone could cut a milestone release for WiQuery as well, so I can
>>do
>>further testing with my application.
>>
>>2. Failing tests for components with AjaxLazyLoadPanel
>>
>>It seems that it is not possible anymore, to load an AjaxLazyLoadPanel
>>during an Ajax request. I have a panel that is initially invisible and
>>shown via an Ajax toggle link that contains a AjaxLazyLoadPanel. My
>>test
>>fails with:
>>
>>java.lang.IllegalStateException: Components can no  longer be added
>>> at
>>>
>>org.apache.wicket.page.PartialPageUpdate.assertNotFrozen(PartialPageUpdate.java:854)
>>> at
>>>
>>org.apache.wicket.page.PartialPageUpdate.assertComponentsNotFrozen(PartialPageUpdate.java:847)
>>> at
>>org.apache.wicket.page.PartialPageUpdate.add(PartialPageUpdate.java:444)
>>> at
>>>
>>org.apache.wicket.ajax.AjaxRequestHandler.add(AjaxRequestHandler.java:263)
>>> at
>>>
>>org.apache.wicket.ajax.AjaxRequestHandler.add(AjaxRequestHandler.java:239)
>>> at
>>>
>>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.lambda$isLoaded$1(AjaxLazyLoadPanel.java:258)
>>> at java.util.Optional.ifPresent(Optional.java:159)
>>> at
>>>
>>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.isLoaded(AjaxLazyLoadPanel.java:258)
>>> at
>>>
>>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.onConfigure(AjaxLazyLoadPanel.java:212)
>>
>>
>>The toggle link sets the panel containing the lazy-load panel visible
>>and
>>adds it to the ajax target:
>>
>>public void onClick(AjaxRequestTarget target) {
>>> component.setVisible(!component.isVisible());
>>> target.add(component);
>>> }
>>
>>
>>3. Removed (internal) APIs
>>
>>I have a custom component for rendering an infinite-scrolling list
>that
>>uses two (internal) methods to update the underlying DataView:
>>
>>public void onClick(AjaxRequestTarget target) {
>>> pageable.setItemsPerPage(pageable.getItemsPerPage() +
>>> additionalItems);
>>
>>view.prepareForRender();
>>> view.afterRender();
>>
>>}
>>
>>
>>Both `prepareForRender` and `afterRender` are no longer accessible.
>>Does
>>anyone have a suggestion what I could call instead? I sadly do not
>>remember
>>why exactly we work against Wicket's default rendering in that case
>but
>>it
>>looks like we want to do everything *except* the actual render.
>>
>>Best regards,
>>
>>Thomas


Re: Issues upgrading to Wicket 8.0.0-M9

2018-02-19 Thread Sven Meier
Hi,

many thanks for following our milestones closely.

Could you please provide a quickstart for 2)?

Regarding 3): Alternative would be calling beforeRender() instead. I'm not sure 
whether that will work for you though, without understanding why you called 
that internal API at all.

Best regards
Sven

⁣Gesendet mit Blue ​

Am 19. Feb. 2018, 11:22, um 11:22, Thomas Heigl  schrieb:
>Hi all,
>
>I upgraded my application from M8 to M9 yesterday and encountered 3
>issues:
>
>1. Current WiQuery version is not compatible with M9
>
>It still depends on WicketEventJQueryResourceReference. It would be
>great
>if someone could cut a milestone release for WiQuery as well, so I can
>do
>further testing with my application.
>
>2. Failing tests for components with AjaxLazyLoadPanel
>
>It seems that it is not possible anymore, to load an AjaxLazyLoadPanel
>during an Ajax request. I have a panel that is initially invisible and
>shown via an Ajax toggle link that contains a AjaxLazyLoadPanel. My
>test
>fails with:
>
>java.lang.IllegalStateException: Components can no  longer be added
>> at
>>
>org.apache.wicket.page.PartialPageUpdate.assertNotFrozen(PartialPageUpdate.java:854)
>> at
>>
>org.apache.wicket.page.PartialPageUpdate.assertComponentsNotFrozen(PartialPageUpdate.java:847)
>> at
>org.apache.wicket.page.PartialPageUpdate.add(PartialPageUpdate.java:444)
>> at
>>
>org.apache.wicket.ajax.AjaxRequestHandler.add(AjaxRequestHandler.java:263)
>> at
>>
>org.apache.wicket.ajax.AjaxRequestHandler.add(AjaxRequestHandler.java:239)
>> at
>>
>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.lambda$isLoaded$1(AjaxLazyLoadPanel.java:258)
>> at java.util.Optional.ifPresent(Optional.java:159)
>> at
>>
>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.isLoaded(AjaxLazyLoadPanel.java:258)
>> at
>>
>org.apache.wicket.extensions.ajax.markup.html.AjaxLazyLoadPanel.onConfigure(AjaxLazyLoadPanel.java:212)
>
>
>The toggle link sets the panel containing the lazy-load panel visible
>and
>adds it to the ajax target:
>
>public void onClick(AjaxRequestTarget target) {
>> component.setVisible(!component.isVisible());
>> target.add(component);
>> }
>
>
>3. Removed (internal) APIs
>
>I have a custom component for rendering an infinite-scrolling list that
>uses two (internal) methods to update the underlying DataView:
>
>public void onClick(AjaxRequestTarget target) {
>> pageable.setItemsPerPage(pageable.getItemsPerPage() +
>> additionalItems);
>
>view.prepareForRender();
>> view.afterRender();
>
>}
>
>
>Both `prepareForRender` and `afterRender` are no longer accessible.
>Does
>anyone have a suggestion what I could call instead? I sadly do not
>remember
>why exactly we work against Wicket's default rendering in that case but
>it
>looks like we want to do everything *except* the actual render.
>
>Best regards,
>
>Thomas