Re: Joda-time dependency

2017-09-30 Thread Maxim Solodovnik
Hello All, I believe this work is almost complete Could you please take a look at the code? The only improvement I see is to create version of DateTimeField component which will work with LocalDateTime instead of ZonedDateTime I'm not sure how this can be done without copy/pasting :((( And we

Re: Joda-time dependency

2017-09-26 Thread Maxim Solodovnik
I have commited huge changes to wicket-extensions datetime could you please take a look at current code? I wonder if I'm moving in the right direction :) Thanks in advance! On Tue, Sep 26, 2017 at 10:34 PM, Sven Meier wrote: > Hi, > > wicket-util already has both converters. >

Re: Joda-time dependency

2017-09-26 Thread Sven Meier
Hi, wicket-util already has both converters. Have fun Sven Am 26.09.2017 um 12:29 schrieb Maxim Solodovnik: Hello Sven, I have updated WICKET-6105 description with your improvement and have started to work on it. I got questions :)) I believe both DateConverter (to perform conversion

Re: Joda-time dependency

2017-09-26 Thread Maxim Solodovnik
Hello Sebastien, I'm working on it :) On Tue, Sep 26, 2017 at 9:04 PM, Sebastien wrote: > Hi Maxim, > > I didn't saw a LocalDateTime converter in the previous commit. If it is the > case, would it be worth it? > > https://github.com/sebfz1/wicket-jquery-ui/blob/wicket8. >

Re: Joda-time dependency

2017-09-26 Thread Sebastien
Hi Maxim, I didn't saw a LocalDateTime converter in the previous commit. If it is the case, would it be worth it? https://github.com/sebfz1/wicket-jquery-ui/blob/wicket8.x/wicket-kendo-ui/src/main/java/com/googlecode/wicket/kendo/ui/form/datetime/local/DateTimePicker.java#L326 Thanks in

Re: Joda-time dependency

2017-09-26 Thread Sebastien
On Tue, Sep 26, 2017 at 12:38 PM, Martin Grigorov wrote: > On Tue, Sep 26, 2017 at 1:29 PM, Maxim Solodovnik > wrote: > > > Hello Sven, > > > > I have updated WICKET-6105 description with your improvement and have > > started to work on it. > > > > I

Re: Joda-time dependency

2017-09-26 Thread Martin Grigorov
On Tue, Sep 26, 2017 at 1:29 PM, Maxim Solodovnik wrote: > Hello Sven, > > I have updated WICKET-6105 description with your improvement and have > started to work on it. > > I got questions :)) > I believe both DateConverter (to perform conversion to/from java.util.Date) >

Re: Joda-time dependency

2017-09-26 Thread Maxim Solodovnik
Hello Sven, I have updated WICKET-6105 description with your improvement and have started to work on it. I got questions :)) I believe both DateConverter (to perform conversion to/from java.util.Date) and LocalDateConverter should exist in wicket WDYT? On Tue, Sep 26, 2017 at 3:08 PM, Maxim

Re: Joda-time dependency

2017-09-26 Thread Maxim Solodovnik
Now it works, Thanks a lot Martin :) On Tue, Sep 26, 2017 at 2:20 AM, Martin Grigorov wrote: > Do you have more than one JIRA users ?! > I've added you to all possible groups in WICKET's JIRA. You must have even > Admin rights. > I'm afraid you should ask Infra for more

Re: Joda-time dependency

2017-09-25 Thread Martin Grigorov
Do you have more than one JIRA users ?! I've added you to all possible groups in WICKET's JIRA. You must have even Admin rights. I'm afraid you should ask Infra for more help if the issue persists. Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Sep 25, 2017

Re: Joda-time dependency

2017-09-25 Thread Maxim Solodovnik
Thanks Martin, but I'm still unable to change description or add comment :( On Mon, Sep 25, 2017 at 1:17 PM, Martin Grigorov wrote: > On Sat, Sep 23, 2017 at 7:27 PM, Maxim Solodovnik > wrote: > >> It seems I'm unable to edit >>

Re: Joda-time dependency

2017-09-25 Thread Martin Grigorov
On Sat, Sep 23, 2017 at 7:27 PM, Maxim Solodovnik wrote: > It seems I'm unable to edit > https://issues.apache.org/jira/browse/WICKET-6105 (to add points proposed > be Sven) > Can someone please grant me rights? > Done! I've re-assigned the ticket to you! Thank you, Maxim!

Re: Joda-time dependency

2017-09-23 Thread Maxim Solodovnik
It seems I'm unable to edit https://issues.apache.org/jira/browse/WICKET-6105 (to add points proposed be Sven) Can someone please grant me rights? On Sat, Sep 23, 2017 at 11:20 PM, Maxim Solodovnik wrote: > Thanks Sven, > > Here is the PR with the current changes > Will

Re: Joda-time dependency

2017-09-23 Thread Maxim Solodovnik
Thanks Sven, Here is the PR with the current changes Will try to work on it tomorrow On Sat, Sep 23, 2017 at 3:57 PM, Sven Meier wrote: > Hi, > > there are many topics to improve on: > > - DateConverter should be name DateTimeConverter and convert to > LocalDateTime > -

Re: Joda-time dependency

2017-09-23 Thread Sven Meier
Hi, there are many topics to improve on: - DateConverter should be name DateTimeConverter and convert to LocalDateTime - DateField should work on a LocalDate (no longer extending DateTimeField) - without the DatePicker we could merge DateField and DateTextField - TimeField should work on a

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
Local build is successful, could someone please review the changes? And I bet some additional classes/methods will be required ... On Sat, Sep 23, 2017 at 12:22 AM, Maxim Solodovnik wrote: > I have commited the code to WICKET-6105-java.time branch > The code is compilable

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
I have commited the code to WICKET-6105-java.time branch The code is compilable (merged with master) But tests fails, will try to continue this work on the weekend On Fri, Sep 22, 2017 at 10:55 PM, Maxim Solodovnik wrote: > Just re-read description for WICKET-6105 >

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
Just re-read description for WICKET-6105 , will try to continue the work started by Martin in the same branch On Fri, Sep 22, 2017 at 10:04 PM, Maxim Solodovnik wrote: > I read through

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
I read through http://markmail.org/thread/uqu6gfma6wihwcwt And It seems all I need to do is to remove wicket-datetime module and all references Is this correct? On Fri, Sep 22, 2017 at 9:47 PM, Maxim Solodovnik wrote: > Done: https://github.com/wicketstuff/core/commit/ >

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
Done: https://github.com/wicketstuff/core/commit/4f4a945d3fca0f856b8ec4f7e065da5f980feec6 On Fri, Sep 22, 2017 at 8:28 PM, Maxim Solodovnik wrote: > Will perform further changes in wicketstuff > Will copy examples > > On Fri, Sep 22, 2017 at 8:20 PM, Maxim Solodovnik

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
Will perform further changes in wicketstuff Will copy examples On Fri, Sep 22, 2017 at 8:20 PM, Maxim Solodovnik wrote: > Here is the wicketstuff module: https://github.com/ > wicketstuff/core/commit/6fd9af625e7d7679ce438ad2df59bf47c1aa487b > Please review > > Will start

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
Here is the wicketstuff module: https://github.com/wicketstuff/core/commit/6fd9af625e7d7679ce438ad2df59bf47c1aa487b Please review Will start to work on wicket On Fri, Sep 22, 2017 at 7:34 PM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > +1 me too > > 2017-09-22 15:28 GMT+03:00

Re: Joda-time dependency

2017-09-22 Thread Martin Makundi
+1 me too 2017-09-22 15:28 GMT+03:00 Andrea Del Bene : > +1 for me. But I doubt there will be something left in wicket-datetime > when you will remove Joda :-) > > > > On 22/09/2017 13:49, Maxim Solodovnik wrote: > >> OK, I'm ready to start :) >> >> As far as I understand

Re: Joda-time dependency

2017-09-22 Thread Andrea Del Bene
+1 for me. But I doubt there will be something left in wicket-datetime when you will remove Joda :-) On 22/09/2017 13:49, Maxim Solodovnik wrote: OK, I'm ready to start :) As far as I understand here is the plan: 1) move existing unchanged wicket-datetime to wicketstuff (8.0.0 only change

Re: Joda-time dependency

2017-09-22 Thread Maxim Solodovnik
OK, I'm ready to start :) As far as I understand here is the plan: 1) move existing unchanged wicket-datetime to wicketstuff (8.0.0 only change package) 2) remove joda-time from wicket-datetime (pom, README.md) 3) use LocalDate/LocalDateTime where appropriate Shall I proceed :))) ? On Wed, Sep

Re: Joda-time dependency

2017-09-20 Thread Martin Grigorov
https://github.com/menodata/time4j - in case Java 8 Date APIs are not good enough Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Tue, Sep 19, 2017 at 10:05 AM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > 2017-09-19 9:35 GMT+03:00 Martin

Re: Joda-time dependency

2017-09-19 Thread Martin Makundi
2017-09-19 9:35 GMT+03:00 Martin Grigorov : > On Tue, Sep 19, 2017 at 8:12 AM, Martin Makundi < > martin.maku...@koodaripalvelut.com> wrote: > > > 2017-09-19 7:16 GMT+03:00 Martin Grigorov : > > > > > On Sep 19, 2017 6:22 AM, "Martin Makundi" < > >

Re: Joda-time dependency

2017-09-19 Thread Martin Grigorov
On Tue, Sep 19, 2017 at 8:12 AM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > 2017-09-19 7:16 GMT+03:00 Martin Grigorov : > > > On Sep 19, 2017 6:22 AM, "Martin Makundi" < > > martin.maku...@koodaripalvelut.com> wrote: > > > > IMO it's better to big

Re: Joda-time dependency

2017-09-18 Thread Martin Makundi
2017-09-19 7:16 GMT+03:00 Martin Grigorov : > On Sep 19, 2017 6:22 AM, "Martin Makundi" < > martin.maku...@koodaripalvelut.com> wrote: > > IMO it's better to big mang whole wicket to drop joda date. All wicket 8 > without joda. > > > Said the person who still uses

Re: Joda-time dependency

2017-09-18 Thread Martin Grigorov
On Sep 19, 2017 6:22 AM, "Martin Makundi" < martin.maku...@koodaripalvelut.com> wrote: IMO it's better to big mang whole wicket to drop joda date. All wicket 8 without joda. Said the person who still uses Wicket 1.4 for his apps... Everyone wants to see the Big Bang and this might be the

Re: Joda-time dependency

2017-09-18 Thread Martin Makundi
IMO it's better to big mang whole wicket to drop joda date. All wicket 8 without joda. ** Martin 2017-09-18 22:43 GMT+03:00 Martin Grigorov : > On Mon, Sep 18, 2017 at 6:50 AM, Martin Makundi < > martin.maku...@koodaripalvelut.com> wrote: > > > Is it possible to also drop

Re: Joda-time dependency

2017-09-18 Thread Martin Grigorov
On Mon, Sep 18, 2017 at 6:50 AM, Martin Makundi < martin.maku...@koodaripalvelut.com> wrote: > Is it possible to also drop joda from wicketstuff for consistency? > IMO, the WicketStuff module must be exactly the same as the one in Wicket 7.x. Any changes in the API should be done in Wicket 8.x.

Re: Joda-time dependency

2017-09-17 Thread Maxim Solodovnik
So far I did no changes I'll start the movement this week, hopefully today of tomorrow On Mon, Sep 18, 2017 at 11:19 AM, Martin Makundi wrote: > Did you drop it from the pom already so that joda is not visible in the > scope? > > 2017-09-18 6:57 GMT+03:00

Re: Joda-time dependency

2017-09-17 Thread Martin Makundi
Did you drop it from the pom already so that joda is not visible in the scope? 2017-09-18 6:57 GMT+03:00 Maxim Solodovnik : > date-time module will not have joda-time dependency after moving > Other modules might have this dependency ... > > On Mon, Sep 18, 2017 at 10:50

Re: Joda-time dependency

2017-09-17 Thread Maxim Solodovnik
date-time module will not have joda-time dependency after moving Other modules might have this dependency ... On Mon, Sep 18, 2017 at 10:50 AM, Martin Makundi wrote: > Is it possible to also drop joda from wicketstuff for consistency? > > 2017-09-17 22:09

Re: Joda-time dependency

2017-09-17 Thread Martin Makundi
Is it possible to also drop joda from wicketstuff for consistency? 2017-09-17 22:09 GMT+03:00 Andrea Del Bene : > +1 to move legacy code to WicketStuff. For 'legacy code' I mean all the > code based on yui library and class StyleDateConverter which is tailored on > Joda

Re: Joda-time dependency

2017-09-17 Thread Maxim Solodovnik
Ok, will start this week On Mon, Sep 18, 2017 at 2:09 AM, Andrea Del Bene wrote: > +1 to move legacy code to WicketStuff. For 'legacy code' I mean all the code > based on yui library and class StyleDateConverter which is tailored on Joda > time. > > > > On 16/09/2017 14:13,

Re: Joda-time dependency

2017-09-17 Thread Andrea Del Bene
+1 to move legacy code to WicketStuff. For 'legacy code' I mean all the code based on yui library and class StyleDateConverter which is tailored on Joda time. On 16/09/2017 14:13, Martin Grigorov wrote: Hi Maxim, Since I do not use wicket-datetime in my apps I also wanted to break it hard

Re: Joda-time dependency

2017-09-17 Thread Sebastien
Hi Maxim, Good catch! But this is the DateTextField part of wicket-extensions, not the one in wicket-datetime... https://github.com/apache/wicket/blob/master/wicket-extensions/src/main/java/org/apache/wicket/extensions/markup/html/form/DateTextField.java Best regards, Sebastien On Sun, Sep 17,

Re: Joda-time dependency

2017-09-17 Thread Maxim Solodovnik
I'm referring to this [1] dependency `DatePicker extends DateTextField` [1] https://github.com/sebfz1/wicket-jquery-ui/blob/master/wicket-jquery-ui/src/main/java/com/googlecode/wicket/jquery/ui/form/datepicker/DatePicker.java#L37 On Sat, Sep 16, 2017 at 11:22 PM, Sebastien

Re: Joda-time dependency

2017-09-16 Thread Sebastien
Hi Maxim, wicket-jquery-ui do not relied on wicket-datetime. On wicket-jquery-ui < 8.x, java datetime are handled by org.threeten api (which is ISO to java8 datetime) Best regards, Sebastien On Sat, Sep 16, 2017 at 2:26 PM, Maxim Solodovnik wrote: > I'm using kendo

Re: Joda-time dependency

2017-09-16 Thread Maxim Solodovnik
I'm using kendo date-time picker from wicket-jquery-ui And I believe it depends on wicket-datetime Will try to do my best on migration then you will review :) On Sat, Sep 16, 2017 at 7:13 PM, Martin Grigorov wrote: > Hi Maxim, > > Since I do not use wicket-datetime in my

Re: Joda-time dependency

2017-09-16 Thread Martin Grigorov
Hi Maxim, Since I do not use wicket-datetime in my apps I also wanted to break it hard by replacing Joda-Time with Java 8 classes. But people who use it expressed concerns that it will be hard to migrate this way. Everyone will have to do the same for his/her application. I remember Igor even

Re: Joda-time dependency

2017-09-15 Thread Martin Makundi
Just brute force it and we can fine-tune later. 2017-09-14 7:11 GMT+03:00 Maxim Solodovnik : > Hello Martin, > > I tried to continue this work, but it seems I need some information > before I can proceed > Could you please tell me What was the goal of these changes? > > I

Re: Joda-time dependency

2017-09-13 Thread Maxim Solodovnik
Hello Martin, I tried to continue this work, but it seems I need some information before I can proceed Could you please tell me What was the goal of these changes? I would remove joda-time, and use LocalDate, LocalTime instead of Date As I can see you are using ZonedDateTime ... On Mon, Sep

Re: Joda-time dependency

2017-09-11 Thread Martin Grigorov
Yes, if finished on time! Wicket 7 requires Java 7 Martin Grigorov Wicket Training and Consulting https://twitter.com/mtgrigorov On Mon, Sep 11, 2017 at 3:34 PM, Rakesh A wrote: > Hi, > > Is it going to be for Wicket 8 only ? > > Regards, > Rakesh.A > > -- > Sent

Re: Joda-time dependency

2017-09-11 Thread Rakesh A
Hi, Is it going to be for Wicket 8 only ? Regards, Rakesh.A -- Sent from: http://apache-wicket.1842946.n4.nabble.com/Users-forum-f1842947.html - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional

Re: Joda-time dependency

2017-09-11 Thread Martin Grigorov
Hi, There were discussions about dropping the whole wicket-datetime module. Some people prefered to keep it but update to Java 8 APIs. With https://issues.apache.org/jira/browse/WICKET-6105 I've tried but it was so simple. You are welcome to finish the work! Martin Grigorov Wicket Training and

Re: Joda-time dependency

2017-09-11 Thread Martin Makundi
+1 dropping joda time. 2017-09-11 14:02 GMT+03:00 Rakesh A : > Hi, > > Joda-time library dependency in Wicket was added long back for valid > reasons > then. With improvements to Date time API in JDK, do we still need this > dependency ? > Can we replace its usage in