Re: Salve and Guice

2008-10-21 Thread Kristof Jozsa
Hi Edgar, did you use either static weaving or the runtime agent as described at http://code.google.com/p/salve/wiki/ConfiguringInstrumentation ? Kristof On Tue, Oct 21, 2008 at 11:42 AM, Edgar Merino [EMAIL PROTECTED] wrote: I've been searching for information on how to use guice to lookup

Re: Salve and Guice

2008-10-21 Thread Guðmundur Bjarni
I haven't used Salve with Wicket, but I've been using the wicket-guice integration quite extensively. The reason I'm answering this is that I feel that many of the use cases of Salve can be solved with pure vanilla Guice. In cases where you can't control the instantiation of objects, you can use

Re: Salve and Guice

2008-10-21 Thread Igor Vaynberg
there are cases where this approach plain old sucks. as you mentioned, if its not a component you have to use static injection which is fugly class mydataprovider implements idataprovider { public mydataprovider() { InjectorHolder.getInjector().inject(this); } } another problem is that

Re: Salve and Guice

2008-10-21 Thread Guðmundur Bjarni
I agree that static injection is fugly, it makes unit tests very sad and kills puppies, but in some cases its a necessary evil. Lets say for example that it is only needed in a very few cases, then IMO pulling in Salve is a bit of an overkill. I've tried out Salve, liked it but it's a bit of a

Re: Salve and Guice

2008-10-21 Thread Edgar Merino
As far as I know, salve will only modify bytecode, it should do that only once, after the JIT compiler comes in there should be no more overhead. Correct me if I'm wrong, regards. Edgar Merino Guðmundur Bjarni escribió: I agree that static injection is fugly, it makes unit tests very sad

Re: Salve and Guice

2008-10-21 Thread Edgar Merino
Also, InjectorHolder.getInjector().inject(this) does not work with guice, it returns an illegalstateexception saying there's no injector assigned for the holder. It would be nice to have more documentation on how to use salve, regards. Edgar Merino Guðmundur Bjarni escribió: I agree that

Re: Salve and Guice

2008-10-21 Thread Igor Vaynberg
i am not sure where exactly the documentation lacks...there is a wiki that shows how to configure everything. anyways, salve stuff is better taken to the salve discussion group so we dont pollute this list. -igor On Tue, Oct 21, 2008 at 4:02 PM, Edgar Merino [EMAIL PROTECTED] wrote: Also,