Re: Wicket 6 / Modal Dialogs and Safari
https://issues.apache.org/jira/browse/WICKET-4770 -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652120.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
Hi, Please create a ticket at http://issues.apache.org/jira/browse/WICKET and attach the patch. Thanks! On Tue, Sep 18, 2012 at 4:13 AM, Geoff Hayman wrote: > My apologies... the patch file was incomplete. This one supersedes the > previous one > > > http://apache-wicket.1842946.n4.nabble.com/file/n4652075/Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch > Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch > > > > > > -- > View this message in context: > http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652075.html > Sent from the Users forum mailing list archive at Nabble.com. > > - > To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org > For additional commands, e-mail: users-h...@wicket.apache.org > -- Martin Grigorov jWeekend Training, Consulting, Development http://jWeekend.com - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
My apologies... the patch file was incomplete. This one supersedes the previous one http://apache-wicket.1842946.n4.nabble.com/file/n4652075/Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch Fix_to_Wicket_6___Safari_modal_window_drag_issue1.patch -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652075.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
I have a proposed fix - please let me know if I've analyzed the problem correctly. The modal dialog tries to set event.ignore=true if the browser is Safari. This Wicket event data structure used to be passed through to Wicket.Drag.mouseDownHandler as the argument e. However, in the switch over to jQuery events the argument (e) passed to mouseDownHandler is no longer Wicket "event". It is now jQuery event data. There is a test in mouseDownHandler to check for the existence of e.ignore. As this is now jQuery data, it _never_ exists, so Safari is never recognized. I changed this test to check event.ignore and it appears to work correctly. Patch file attached. http://apache-wicket.1842946.n4.nabble.com/file/n4652074/Fix_to_Wicket_6___Safari_modal_window_drag_issue.patch Fix_to_Wicket_6___Safari_modal_window_drag_issue.patch -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652074.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org
Re: Wicket 6 / Modal Dialogs and Safari
This issue can also be seen here: http://www.wicket-library.com/wicket-examples-6.0.x/ajax/modal-window Using Safari, the dialog appears to resize rather that select input fields -- View this message in context: http://apache-wicket.1842946.n4.nabble.com/Wicket-6-Modal-Dialogs-and-Safari-tp4652066p4652068.html Sent from the Users forum mailing list archive at Nabble.com. - To unsubscribe, e-mail: users-unsubscr...@wicket.apache.org For additional commands, e-mail: users-h...@wicket.apache.org