Re: markup not found on feedback panel (wicket 7.4)

2018-02-15 Thread Ernesto Reinaldo Barreiro
Voila

https://issues.apache.org/jira/browse/WICKET-6538

On Thu, Feb 15, 2018 at 3:30 PM, Martin Grigorov 
wrote:

> On Thu, Feb 15, 2018 at 12:43 PM, Ernesto Reinaldo Barreiro <
> reier...@gmail.com> wrote:
>
> > Hi Martin,
> >
> > Many thanks for your answer.
> >
> >
> > > > -Could this be prevented by wicket somehow?
> > > >
> > >
> > > I do not see how.
> > > If the component is in the tree then the visitor will see it and add it
> > to
> > > ART.
> > >
> >
> > I mean component is added ==> even if not visible check if markup is
> there
> > (early complain about the problem). Real problem was hidden til ART make
> it
> > appear.
> >
> >
> > >
> > > > - If not, at least provide a more meaningful/helpful error message
> (e.g
> > > > context in which markup is not found)?
> > > >
> > >
> > > Definitely!
> > > Wicket can/should log the component path instead of just the component
> > id.
> > > This will make it much easier to debug the problem.
> > >
> >
> > Yes that would be great. Should I create an ISSUE for that? Maybe + PR
> :-)
> >
>
> Yes, please!
>
>
> >
> > >
> > >
> > > >
> > > >
> > > >
> > > >
> > > > On Thu, Feb 8, 2018 at 6:44 AM, Ernesto Reinaldo Barreiro <
> > > > reier...@gmail.com> wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > On one application we are getting sporadic errors like
> > > > >
> > > > > org.apache.wicket.markup.MarkupNotFoundException: Markup not found
> > for
> > > > > Component: [FencedFeedbackPanel [Component id = feedback]]
> > > > > at org.apache.wicket.Component.internalRender(Component.java:2348)
> > > > > at org.apache.wicket.Component.render(Component.java:2308)
> > > > > at org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(
> > > > > XmlPartialPageUpdate.java:119)
> > > > > at org.apache.wicket.page.PartialPageUpdate.writeComponents(
> > > > > PartialPageUpdate.java:248)
> > > > > at org.apache.wicket.page.PartialPageUpdate.writeTo(
> > > > > PartialPageUpdate.java:161)
> > > > > at org.apache.wicket.ajax.AjaxRequestHandler.respond(
> > > > > AjaxRequestHandler.java:358)
> > > > > at org.apache.wicket.request.cycle.RequestCycle$
> > > HandlerExecutor.respond(
> > > > > RequestCycle.java:895)
> > > > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > > > RequestHandlerStack.java:64)
> > > > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > > > RequestHandlerStack.java:97)
> > > > > a
> > > > >
> > > > > Error is not always produced. I have been checking JIRA and the
> only
> > > > thing
> > > > > I have found that looks similar is
> > > > >
> > > > > https://issues.apache.org/jira/browse/WICKET-6027
> > > > >
> > > > > But we are on 7.4 and it does not seem to be the same combination
> of
> > > > > factors. If we could avoid going to newer versions and find why and
> > > > > "workaround" that would be ideal.
> > > > >
> > > > > Any hints? Related know issues?
> > > > >
> > > > > --
> > > > > Regards - Ernesto Reinaldo Barreiro
> > > > >
> > > >
> > > >
> > > >
> > > > --
> > > > Regards - Ernesto Reinaldo Barreiro
> > > >
> > >
> >
> >
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>



-- 
Regards - Ernesto Reinaldo Barreiro


Re: markup not found on feedback panel (wicket 7.4)

2018-02-15 Thread Martin Grigorov
On Thu, Feb 15, 2018 at 12:43 PM, Ernesto Reinaldo Barreiro <
reier...@gmail.com> wrote:

> Hi Martin,
>
> Many thanks for your answer.
>
>
> > > -Could this be prevented by wicket somehow?
> > >
> >
> > I do not see how.
> > If the component is in the tree then the visitor will see it and add it
> to
> > ART.
> >
>
> I mean component is added ==> even if not visible check if markup is there
> (early complain about the problem). Real problem was hidden til ART make it
> appear.
>
>
> >
> > > - If not, at least provide a more meaningful/helpful error message (e.g
> > > context in which markup is not found)?
> > >
> >
> > Definitely!
> > Wicket can/should log the component path instead of just the component
> id.
> > This will make it much easier to debug the problem.
> >
>
> Yes that would be great. Should I create an ISSUE for that? Maybe + PR :-)
>

Yes, please!


>
> >
> >
> > >
> > >
> > >
> > >
> > > On Thu, Feb 8, 2018 at 6:44 AM, Ernesto Reinaldo Barreiro <
> > > reier...@gmail.com> wrote:
> > >
> > > > Hi,
> > > >
> > > > On one application we are getting sporadic errors like
> > > >
> > > > org.apache.wicket.markup.MarkupNotFoundException: Markup not found
> for
> > > > Component: [FencedFeedbackPanel [Component id = feedback]]
> > > > at org.apache.wicket.Component.internalRender(Component.java:2348)
> > > > at org.apache.wicket.Component.render(Component.java:2308)
> > > > at org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(
> > > > XmlPartialPageUpdate.java:119)
> > > > at org.apache.wicket.page.PartialPageUpdate.writeComponents(
> > > > PartialPageUpdate.java:248)
> > > > at org.apache.wicket.page.PartialPageUpdate.writeTo(
> > > > PartialPageUpdate.java:161)
> > > > at org.apache.wicket.ajax.AjaxRequestHandler.respond(
> > > > AjaxRequestHandler.java:358)
> > > > at org.apache.wicket.request.cycle.RequestCycle$
> > HandlerExecutor.respond(
> > > > RequestCycle.java:895)
> > > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > > RequestHandlerStack.java:64)
> > > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > > RequestHandlerStack.java:97)
> > > > a
> > > >
> > > > Error is not always produced. I have been checking JIRA and the only
> > > thing
> > > > I have found that looks similar is
> > > >
> > > > https://issues.apache.org/jira/browse/WICKET-6027
> > > >
> > > > But we are on 7.4 and it does not seem to be the same combination of
> > > > factors. If we could avoid going to newer versions and find why and
> > > > "workaround" that would be ideal.
> > > >
> > > > Any hints? Related know issues?
> > > >
> > > > --
> > > > Regards - Ernesto Reinaldo Barreiro
> > > >
> > >
> > >
> > >
> > > --
> > > Regards - Ernesto Reinaldo Barreiro
> > >
> >
>
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>


Re: markup not found on feedback panel (wicket 7.4)

2018-02-15 Thread Ernesto Reinaldo Barreiro
Hi Martin,

Many thanks for your answer.


> > -Could this be prevented by wicket somehow?
> >
>
> I do not see how.
> If the component is in the tree then the visitor will see it and add it to
> ART.
>

I mean component is added ==> even if not visible check if markup is there
(early complain about the problem). Real problem was hidden til ART make it
appear.


>
> > - If not, at least provide a more meaningful/helpful error message (e.g
> > context in which markup is not found)?
> >
>
> Definitely!
> Wicket can/should log the component path instead of just the component id.
> This will make it much easier to debug the problem.
>

Yes that would be great. Should I create an ISSUE for that? Maybe + PR :-)

>
>
> >
> >
> >
> >
> > On Thu, Feb 8, 2018 at 6:44 AM, Ernesto Reinaldo Barreiro <
> > reier...@gmail.com> wrote:
> >
> > > Hi,
> > >
> > > On one application we are getting sporadic errors like
> > >
> > > org.apache.wicket.markup.MarkupNotFoundException: Markup not found for
> > > Component: [FencedFeedbackPanel [Component id = feedback]]
> > > at org.apache.wicket.Component.internalRender(Component.java:2348)
> > > at org.apache.wicket.Component.render(Component.java:2308)
> > > at org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(
> > > XmlPartialPageUpdate.java:119)
> > > at org.apache.wicket.page.PartialPageUpdate.writeComponents(
> > > PartialPageUpdate.java:248)
> > > at org.apache.wicket.page.PartialPageUpdate.writeTo(
> > > PartialPageUpdate.java:161)
> > > at org.apache.wicket.ajax.AjaxRequestHandler.respond(
> > > AjaxRequestHandler.java:358)
> > > at org.apache.wicket.request.cycle.RequestCycle$
> HandlerExecutor.respond(
> > > RequestCycle.java:895)
> > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > RequestHandlerStack.java:64)
> > > at org.apache.wicket.request.RequestHandlerStack.execute(
> > > RequestHandlerStack.java:97)
> > > a
> > >
> > > Error is not always produced. I have been checking JIRA and the only
> > thing
> > > I have found that looks similar is
> > >
> > > https://issues.apache.org/jira/browse/WICKET-6027
> > >
> > > But we are on 7.4 and it does not seem to be the same combination of
> > > factors. If we could avoid going to newer versions and find why and
> > > "workaround" that would be ideal.
> > >
> > > Any hints? Related know issues?
> > >
> > > --
> > > Regards - Ernesto Reinaldo Barreiro
> > >
> >
> >
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>



-- 
Regards - Ernesto Reinaldo Barreiro


Re: markup not found on feedback panel (wicket 7.4)

2018-02-15 Thread Martin Grigorov
On Thu, Feb 15, 2018 at 11:26 AM, Ernesto Reinaldo Barreiro <
reier...@gmail.com> wrote:

> Hi.
>
> Just a follow up...  Issue was as follows.
>
> - Application contains many dialogs (jquery modal). In some dialog A there
> was a feedback panel ("feedback"). This feedback panel was set visible =
> false
> - Dialog B extended dialog A and also provided a B.html but this panel did
> not contain a DIV for "feedback". As this component was invisible panel B
> just rendered fine. Feedback panel is never rendered (no error messages).
> And user closes the modal panel B and continues doing things on
> application.
> - Later on application has some other logic with a visitor that adds all
> feedback panels to an ART... and then we get message above.
>
> As application has many feedback panels and this happens few "steps/user
> actions" after panel B is used this was rather disconcerting. Fortunately
> we manage to and spot/fix problem (provide "feedback markup on B").
>
> See this problem illustrated in a very simple quick-start application
>
> https://github.com/reiern70/visibility
>
> My questions are.
>
> -Could this be prevented by wicket somehow?
>

I do not see how.
If the component is in the tree then the visitor will see it and add it to
ART.


> - If not, at least provide a more meaningful/helpful error message (e.g
> context in which markup is not found)?
>

Definitely!
Wicket can/should log the component path instead of just the component id.
This will make it much easier to debug the problem.


>
>
>
>
> On Thu, Feb 8, 2018 at 6:44 AM, Ernesto Reinaldo Barreiro <
> reier...@gmail.com> wrote:
>
> > Hi,
> >
> > On one application we are getting sporadic errors like
> >
> > org.apache.wicket.markup.MarkupNotFoundException: Markup not found for
> > Component: [FencedFeedbackPanel [Component id = feedback]]
> > at org.apache.wicket.Component.internalRender(Component.java:2348)
> > at org.apache.wicket.Component.render(Component.java:2308)
> > at org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(
> > XmlPartialPageUpdate.java:119)
> > at org.apache.wicket.page.PartialPageUpdate.writeComponents(
> > PartialPageUpdate.java:248)
> > at org.apache.wicket.page.PartialPageUpdate.writeTo(
> > PartialPageUpdate.java:161)
> > at org.apache.wicket.ajax.AjaxRequestHandler.respond(
> > AjaxRequestHandler.java:358)
> > at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(
> > RequestCycle.java:895)
> > at org.apache.wicket.request.RequestHandlerStack.execute(
> > RequestHandlerStack.java:64)
> > at org.apache.wicket.request.RequestHandlerStack.execute(
> > RequestHandlerStack.java:97)
> > a
> >
> > Error is not always produced. I have been checking JIRA and the only
> thing
> > I have found that looks similar is
> >
> > https://issues.apache.org/jira/browse/WICKET-6027
> >
> > But we are on 7.4 and it does not seem to be the same combination of
> > factors. If we could avoid going to newer versions and find why and
> > "workaround" that would be ideal.
> >
> > Any hints? Related know issues?
> >
> > --
> > Regards - Ernesto Reinaldo Barreiro
> >
>
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>


Re: markup not found on feedback panel (wicket 7.4)

2018-02-15 Thread Ernesto Reinaldo Barreiro
Hi.

Just a follow up...  Issue was as follows.

- Application contains many dialogs (jquery modal). In some dialog A there
was a feedback panel ("feedback"). This feedback panel was set visible =
false
- Dialog B extended dialog A and also provided a B.html but this panel did
not contain a DIV for "feedback". As this component was invisible panel B
just rendered fine. Feedback panel is never rendered (no error messages).
And user closes the modal panel B and continues doing things on application.
- Later on application has some other logic with a visitor that adds all
feedback panels to an ART... and then we get message above.

As application has many feedback panels and this happens few "steps/user
actions" after panel B is used this was rather disconcerting. Fortunately
we manage to and spot/fix problem (provide "feedback markup on B").

See this problem illustrated in a very simple quick-start application

https://github.com/reiern70/visibility

My questions are.

-Could this be prevented by wicket somehow?
- If not, at least provide a more meaningful/helpful error message (e.g
context in which markup is not found)?




On Thu, Feb 8, 2018 at 6:44 AM, Ernesto Reinaldo Barreiro <
reier...@gmail.com> wrote:

> Hi,
>
> On one application we are getting sporadic errors like
>
> org.apache.wicket.markup.MarkupNotFoundException: Markup not found for
> Component: [FencedFeedbackPanel [Component id = feedback]]
> at org.apache.wicket.Component.internalRender(Component.java:2348)
> at org.apache.wicket.Component.render(Component.java:2308)
> at org.apache.wicket.page.XmlPartialPageUpdate.writeComponent(
> XmlPartialPageUpdate.java:119)
> at org.apache.wicket.page.PartialPageUpdate.writeComponents(
> PartialPageUpdate.java:248)
> at org.apache.wicket.page.PartialPageUpdate.writeTo(
> PartialPageUpdate.java:161)
> at org.apache.wicket.ajax.AjaxRequestHandler.respond(
> AjaxRequestHandler.java:358)
> at org.apache.wicket.request.cycle.RequestCycle$HandlerExecutor.respond(
> RequestCycle.java:895)
> at org.apache.wicket.request.RequestHandlerStack.execute(
> RequestHandlerStack.java:64)
> at org.apache.wicket.request.RequestHandlerStack.execute(
> RequestHandlerStack.java:97)
> a
>
> Error is not always produced. I have been checking JIRA and the only thing
> I have found that looks similar is
>
> https://issues.apache.org/jira/browse/WICKET-6027
>
> But we are on 7.4 and it does not seem to be the same combination of
> factors. If we could avoid going to newer versions and find why and
> "workaround" that would be ideal.
>
> Any hints? Related know issues?
>
> --
> Regards - Ernesto Reinaldo Barreiro
>



-- 
Regards - Ernesto Reinaldo Barreiro