Re: [v8-dev] Design Doc: v8::String::WriteUtf8() without flattening

2023-12-13 Thread Ben Noordhuis
On Wed, Dec 13, 2023 at 5:37 PM Caitlin Potter wrote: > > I've shared this on Slack already, hoping to get a few more eyes on it via > v8-dev. > https://docs.google.com/document/d/1jn6KFlrnfGwI1f7eLS7QQ7STzN58voONCk4TuCMt7es/edit?usp=sharing > > The primary goal here is to enable the option to

[v8-dev] custom code blows up when printing output of v8::JSON::Stringify

2023-12-13 Thread Jeff Greer
I have a set of static configuration properties that are exposed. These properties are set to defaults in my c++ code. They can be changed in a Javascript script. String and integer types seem to work correctly, but when I have bool data things go south quickly. When the bool data is set to

Re: [v8-dev] Failure when building on mac

2023-12-13 Thread Meir Shpilraien
I am actually using use_custom_libcxx=false On Wednesday 13 December 2023 at 15:24:48 UTC+2 les...@chromium.org wrote: > This looks like a C++20 build using a non C++20 standard lib. Adding > Helmut who landed the change (https://crrev.com/c/5079350) -- if it's > causing issues it's an easy

[v8-dev] Design Doc: v8::String::WriteUtf8() without flattening

2023-12-13 Thread Caitlin Potter
I've shared this on Slack already, hoping to get a few more eyes on it via v8-dev. https://docs.google.com/document/d/1jn6KFlrnfGwI1f7eLS7QQ7STzN58voONCk4TuCMt7es/edit?usp=sharing The primary goal here is to enable the option to read or process string contents safely in embedder functions

Re: [v8-dev] Re: Crash Issue Encountered in V8 Version 11.0.20.226 During Heap Snapshot

2023-12-13 Thread 苏世睿
Hi! Is there any progress on this? Or am I currently performing a non-standard operation? 苏世睿 于2023年12月4日周一 12:49写道: > I just found a simply way to reproduce this: > Firstly, build d8 with the following args.gn: > > is_debug = true > > symbol_level=2 > > target_cpu = "x64" > > v8_target_cpu =

Re: [v8-dev] Failure when building on mac

2023-12-13 Thread Leszek Swirski
This looks like a C++20 build using a non C++20 standard lib. Adding Helmut who landed the change (https://crrev.com/c/5079350) -- if it's causing issues it's an easy revert. On Wed, Dec 13, 2023 at 9:31 AM Meir Shpilraien wrote: > Hey > > Yesterday we started to see failure on our mac build on

Re: [v8-dev] Failure when building on mac

2023-12-13 Thread Clemens Backes
This is caused by https://crrev.com/c/5079350. I see that you build with -std=c++20, but it seems like the standard library you are using is not C++20-compatible. Do you compile with use_custom_libcxx=true? On Wed, Dec 13, 2023 at 9:31 AM Meir Shpilraien wrote: > Hey > > Yesterday we started to

Re: [v8-dev] Failure when building on mac

2023-12-13 Thread Clemens Backes
This might fix it: https://crrev.com/c/5119542 On Wed, Dec 13, 2023 at 10:42 AM Clemens Backes wrote: > This is caused by https://crrev.com/c/5079350. > I see that you build with -std=c++20, but it seems like the standard > library you are using is not C++20-compatible. Do you compile with >

[v8-dev] Failure when building on mac

2023-12-13 Thread Meir Shpilraien
Hey Yesterday we started to see failure on our mac build on the main branch (which we do not see on official version). The failure: FAILED: obj/torque_generated_definitions/api-callbacks-tq.o 582

[v8-dev] Re: Crash Issue Encountered in V8 Version 11.0.20.226 During Heap Snapshot

2023-12-13 Thread 苏世睿
Hi! Is there any progress on this? Or am I currently performing a non-standard operation? 在2023年12月4日星期一 UTC+8 12:49:08<苏世睿> 写道: > I just found a simply way to reproduce this: > Firstly, build d8 with the following args.gn: > > is_debug = true > > symbol_level=2 > > target_cpu = "x64" > >