Re: [v8-dev] V8 WebAssmebly codegen questions - 64 bit instructions and Vectorization?

2019-09-16 Thread 'Clemens Hammacher' via v8-dev
On Mon, Sep 16, 2019 at 12:41 PM wrote: > Thanks for the responses. > > On Tuesday, 10 September 2019 11:12:36 UTC+1, Ross McIlroy wrote: >> >> To answer one of the questions here (inline): >> >>> [...] >>> 2) Are there plans to transition Play Store Chrome releases to 64-bit >>> for 64-bit

Re: [v8-dev] V8 WebAssmebly codegen questions - 64 bit instructions and Vectorization?

2019-09-11 Thread 'Clemens Hammacher' via v8-dev
On Tue, Sep 10, 2019 at 10:20 AM wrote: > Hi Clemens, > > Thanks for those really helpful pointers. > > I have continued digging into this for the last week or so, and have put > my current code up GitHub for anyone interested: > https://github.com/tangobravo/webassembly-halfsample-benchmark > >

Re: [v8-dev] V8 WebAssmebly codegen questions - 64 bit instructions and Vectorization?

2019-09-03 Thread 'Clemens Hammacher' via v8-dev
Hi Simon, that's an interesting project, please keep us updated :) 1) Does v8 codegen emit 64-bit machine instructions for 64-bit wasm > instructions on 64-bit architectures (specifically Android)? I imagine the > speedup from SWAR techniques will be significantly reduced using just > 32-bit

Re: [v8-dev] gdb-jit support for ARM64

2018-12-14 Thread 'Clemens Hammacher' via v8-dev
Puh, that's a tricky bug. It happens because gdb sets breakpoints by replacing individual instructions with the "int 3" instruction. When executed, this will cause a debug trap which gdb catches. The check fails because we check that the snapshot is correct by recomputing a hash of its content.

Re: [v8-dev] --perf-prof support on ARM64

2018-12-11 Thread 'Clemens Hammacher' via v8-dev
Done. On Tue, Dec 11, 2018 at 5:01 PM wrote: > Thanks Clemens for opening the bug. Can you please add me as a watcher to > this bug. I am not sure if I can do that myself. You can either use my > siris...@gmail.com or sirish.pa...@samsung.com > > Sirish > > On Tuesday, December 11, 2018 at

Re: [v8-dev] Nested steps and sticky Show options

2018-11-12 Thread 'Clemens Hammacher' via v8-dev
This is super helpful, thanks a lot for implementing this, Sergiy! On Sat, Nov 10, 2018 at 6:52 AM Sergiy Byelozyorov wrote: > Hi, > > We have recently implemented support for nested steps on Milo aka LUCI UI: > > [image: yHoZnCkBwNK.png] > > You can collapse/expand individual steps by clicking

Re: [v8-dev] Re: Where "locale" variable comes from? Having "Failed to create ICU number format, are ICU data files missing?"

2018-06-06 Thread 'Clemens Hammacher' via v8-dev
This is unfortunate indeed. I opened a bug for this ( https://crbug.com/v8/7820) and prepared a fix to make %DebugPrint work properly on Android. On Wed, Jun 6, 2018 at 1:20 PM wrote: > I've found v8_android_log_stdout >

Re: [v8-dev] js-flags "--print_wasm_code" "--trace_wasm_interpreter " not working with chromium

2018-04-03 Thread 'Clemens Hammacher' via v8-dev
Hi Radhesh, --print-wasm-code requires disassembler support (gn arg: v8_enable_disassembler), so you probably need to compile your own chromium to use it. --trace-wasm-interpreter is a debug-only flag (gn arg: is_debug), but the wasm interpreter will only be used if breakpoints are set in wasm

[v8-dev] Re: Profiling WASM code.

2018-02-06 Thread 'Clemens Hammacher' via v8-dev
Please go ahead and open a bug for this. I saw at least one TODO about profiling support for native wasm code, but having a bug to track progress seems appropriate. We should also find out how to add regression tests for this. Can you provide insights there? On Tue, Feb 6, 2018 at 2:23 PM Pierre

Re: [v8-dev] v8 jumbo build support

2017-08-03 Thread 'Clemens Hammacher' via v8-dev
Sorry for the delay. I checked src/asmjs and src/wasm. Left three comments, LGTM when they are addressed. On Tue, Aug 1, 2017 at 11:20 PM wrote: > I have some general lgtm's for this CL, but I'm still looking for OWNERS > to review changes in the following directories: >

Re: [v8-dev] Build of 5.7-lkgr fails with default options

2017-03-01 Thread 'Clemens Hammacher' via v8-dev
The fix for this has landed yesterday as https://github.com/v8/v8/commit/6bb221b49ebcac13653477d2d3e01f921a721474. It should work if you just retry. --Clemens On Tue, Feb 28, 2017 at 11:31 AM wrote: > I ran: > > git checkout 5.7-lkgr > gclient sync > make x64.release > >