[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread yangguo
LGTM with a comment. https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160 src/deoptimizer.cc:160: data-ArgumentsStackHeight(deoptimization_index)-value() *

[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread yangguo
On 2015/08/03 11:48:23, Jarin wrote: https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160 src/deoptimizer.cc:160:

[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1264483008/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1264483008/40001 https://codereview.chromium.org/1264483008/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread jarin
https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc File src/deoptimizer.cc (right): https://codereview.chromium.org/1264483008/diff/1/src/deoptimizer.cc#newcode160 src/deoptimizer.cc:160: data-ArgumentsStackHeight(deoptimization_index)-value() * kPointerSize; On 2015/08/03

[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1264483008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: [deoptimizer] Fix the frame size calculation for debugger-inspectable frame construction. (issue 1264483008 by ja...@chromium.org)

2015-08-03 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/156a155be37a32d4b9a14e31ef605df51bf0ab8a Cr-Commit-Position: refs/heads/master@{#29973} https://codereview.chromium.org/1264483008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this