[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #3 (id:40001) https://codereview.chromium.org/1314203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 3 (id:??) landed as https://crrev.com/05f01b3f8e2fbb2eac0f4495d165f928b2679570 Cr-Commit-Position: refs/heads/master@{#30519} https://codereview.chromium.org/1314203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1314203002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1314203002/40001 https://codereview.chromium.org/1314203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread conradw
https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js File test/mjsunit/strong/function-arity.js (left): https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js#oldcode220 test/mjsunit/strong/function-arity.js:220: `'use s

[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread rossberg
LGTM modulo comment https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js File test/mjsunit/strong/function-arity.js (left): https://codereview.chromium.org/1314203002/diff/40001/test/mjsunit/strong/function-arity.js#oldcode220 test/mjsunit/strong/function-

[v8-dev] Re: [strong] Class constructor bodies cannot contain "use strong" directive (issue 1314203002 by conr...@chromium.org)

2015-09-01 Thread conradw
Adding some other reviewers since rossberg is at ICFP, this is blocking a couple of other things. https://codereview.chromium.org/1314203002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the