[v8-dev] Re: [strong] Refactor out separate strong runtime call for class objects (issue 1270393002 by conr...@chromium.org)

2015-08-05 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1270393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and

[v8-dev] Re: [strong] Refactor out separate strong runtime call for class objects (issue 1270393002 by conr...@chromium.org)

2015-08-05 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/2cd2b8cadb4ebafefd4969c99853a3d7fd9d4906 Cr-Commit-Position: refs/heads/master@{#30033} https://codereview.chromium.org/1270393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: [strong] Refactor out separate strong runtime call for class objects (issue 1270393002 by conr...@chromium.org)

2015-08-05 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1270393002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1270393002/20001 https://codereview.chromium.org/1270393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com ht

[v8-dev] Re: [strong] Refactor out separate strong runtime call for class objects (issue 1270393002 by conr...@chromium.org)

2015-08-05 Thread conradw
https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc#newcode266 src/runtime/runtime-classes.cc:266: RETURN_FAILURE_ON_EXCEPTION(isolate, JSObj

[v8-dev] Re: [strong] Refactor out separate strong runtime call for class objects (issue 1270393002 by conr...@chromium.org)

2015-08-05 Thread rossberg
lgtm https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc File src/runtime/runtime-classes.cc (right): https://codereview.chromium.org/1270393002/diff/1/src/runtime/runtime-classes.cc#newcode266 src/runtime/runtime-classes.cc:266: RETURN_FAILURE_ON_EXCEPTION(isolat