[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread ulan
On 2015/07/21 10:04:35, jbramley wrote: What's the purpose of it? Will there be future cases where we don't know the expected size until after the start of the scope? The background is in https://code.google.com/p/v8/issues/detail?id=4277 CallCodeSize() depends on the predictable_code_size_

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread jacob . bramley
What's the purpose of it? Will there be future cases where we don't know the expected size until after the start of the scope? https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread jacob . bramley
It might be more robust to be able to pass the flag to CallCodeSize(), and make it stateless, but that might be a complicated change. LGTM https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1251443002/1 https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/5a556dfe314dbf818599c0f1b2886c733a94a086 Cr-Commit-Position: refs/heads/master@{#29772} https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: ARM: make sure that the expected code size is computed in predictable scope. (issue 1251443002 by u...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1251443002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop