On 2015/06/19 13:55:49, rossberg wrote:
On 2015/06/19 13:45:33, wingo wrote:
On 2015/06/19 13:40:40, rossberg wrote:
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h
File src/messages.h (right):
On 2015/06/19 14:08:38, rossberg wrote:
LGTM
Not for (...x, y) because the (... case reads an identifier and then
does:
[...]
Not for (x, ...y) because that only passes through to
ParseArrowFunctionLiteral
after it has seen the =.
I see. What about about (...pattern) ? :)
Hummm!
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h#newcode327
src/messages.h:327: Expected () to start arrow function, but got '%'
instead of '=')\
Hm, isn't this also
On 2015/06/19 13:45:33, wingo wrote:
On 2015/06/19 13:40:40, rossberg wrote:
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h#newcode327
src/messages.h:327: Expected ()
LGTM
Not for (...x, y) because the (... case reads an identifier and then does:
[...]
Not for (x, ...y) because that only passes through to
ParseArrowFunctionLiteral
after it has seen the =.
I see. What about about (...pattern) ? :)
https://codereview.chromium.org/1191303002/
--
--
On 2015/06/19 14:15:13, wingo wrote:
Hummm! AFAIU parsing this is broken ATM, but FunctionRestParameter is
BindingRestElement which is ... BindingIdentifier, so really (... can
only
be
followed by an identifier.
Interesting, I wasn't aware of this limitation! I had assumed that rest can
On 2015/06/19 13:40:40, rossberg wrote:
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h
File src/messages.h (right):
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h#newcode327
src/messages.h:327: Expected () to start arrow function, but got '%'
On 2015/06/19 13:55:49, rossberg wrote:
On 2015/06/19 13:45:33, wingo wrote:
On 2015/06/19 13:40:40, rossberg wrote:
https://codereview.chromium.org/1191303002/diff/20001/src/messages.h
File src/messages.h (right):
CQ is trying da patch. Follow status at
https://chromium-cq-status.appspot.com/patch-status/1191303002/40001
https://codereview.chromium.org/1191303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are
On 2015/06/19 14:15:13, wingo wrote:
On 2015/06/19 14:08:38, rossberg wrote:
LGTM
Not for (...x, y) because the (... case reads an identifier and then
does:
[...]
Not for (x, ...y) because that only passes through to
ParseArrowFunctionLiteral
after it has seen the =.
I see. What
The author wi...@igalia.com has not signed Google Contributor License
Agreement.
Please visit https://cla.developers.google.com to sign and manage CLA.
https://codereview.chromium.org/1191303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
The author wi...@igalia.com has not signed Google Contributor License
Agreement.
Please visit https://cla.developers.google.com to sign and manage CLA.
https://codereview.chromium.org/1191303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You
Committed patchset #3 (id:40001)
https://codereview.chromium.org/1191303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups v8-dev group.
To unsubscribe from this group and
Patchset 3 (id:??) landed as
https://crrev.com/d940c0272426cb86a963ece05998422cb70284e1
Cr-Commit-Position: refs/heads/master@{#29153}
https://codereview.chromium.org/1191303002/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
14 matches
Mail list logo
