[v8-dev] Re: Bubble up the transitions associated with PreventExtensionsWithTransition (issue 1239803004 by conr...@chromium.org)

2015-09-18 Thread conradw
After some iterations on strong class semantics, this change probably doesn't need to go ahead, since instances are no longer going to be sealed. https://codereview.chromium.org/1239803004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You

[v8-dev] Re: Bubble up the transitions associated with PreventExtensionsWithTransition (issue 1239803004 by conr...@chromium.org)

2015-09-16 Thread ishell
Please also add tests for this functionality. https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/1239803004/diff/20001/src/objects.cc#newcode2367 src/objects.cc:2367: if (!prev_object->IsUndefined()) { How about

[v8-dev] Re: Bubble up the transitions associated with PreventExtensionsWithTransition (issue 1239803004 by conr...@chromium.org)

2015-09-02 Thread rossberg
Igor, given that Toon is away, can you perhaps have a look at this CL? https://codereview.chromium.org/1239803004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev"

[v8-dev] Re: Bubble up the transitions associated with PreventExtensionsWithTransition (issue 1239803004 by conr...@chromium.org)

2015-09-02 Thread conradw
On 2015/09/02 14:53:52, rossberg wrote: Igor, given that Toon is away, can you perhaps have a look at this CL? I'm not completely happy with this CL just now, I was talking to Jakob about this issue recently and it seems like there might be a better way to do it (plus I've still not checked