[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/abc12df33c0dd188441acbf1646048111bdaf1be Cr-Commit-Position: refs/heads/master@{#30134} https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this messag

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290703002/1 https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://gro

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread bmeurer
LGTM, nice catch! https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread mlippautz
heap lgtm https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails f

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread rossberg
lgtm https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Do not save script object on the class constructor. (issue 1290703002 by yang...@chromium.org)

2015-08-12 Thread yangguo
https://codereview.chromium.org/1290703002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails from it, sen