[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1316633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/09b54808b1bdfac9c4dea93796ed8c2a7ffe2f9b Cr-Commit-Position: refs/heads/master@{#30360} https://codereview.chromium.org/1316633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316633002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316633002/20001 https://codereview.chromium.org/1316633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com

[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread bradnelson via v8-dev
PTAL https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116 src/ast-expression-visitor.cc:116: VisitExpression(label); On 2015/08/25

[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread rossberg
lgtm https://codereview.chromium.org/1316633002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Fix AstExpressionVisitor to correctly handle switch + for. (issue 1316633002 by bradnel...@google.com)

2015-08-25 Thread rossberg
https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc File src/ast-expression-visitor.cc (right): https://codereview.chromium.org/1316633002/diff/1/src/ast-expression-visitor.cc#newcode116 src/ast-expression-visitor.cc:116: VisitExpression(label); Why is the label