Note that V8 does not have a commit queue, so the CQ bit isn't operational.
I
will land for you. (Sorry for the delay, I was OOO last week.)
https://codereview.chromium.org/364853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do
CQ is trying da patch. Follow status at
https://v8-status.appspot.com/cq/dp...@igalia.com/364853009/340001
https://codereview.chromium.org/364853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribe
All trybots are green now.
https://codereview.chromium.org/364853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop re
Thanks for the clarifications.
So I'm going to leave the patch as it is and fix the indentation in
harmony-array.js plus add a header comment in AddElemnt. Patch already
uploaded.
I still have issues with the trybots. It seems the trybots cannot apply the
patch because the application of the
On Fri, Aug 8, 2014 at 8:29 AM, wrote:
>
> Let's take the spec of Array.prototype.map for example. The spec describes
> the
> following steps:
>
>* Let mappedValue be the result of calling the Call internal method of
> callbackfn with T as thisArgument and a List containing kValue, k, and O a
On 2014/08/08 12:53:38, rossberg wrote:
For the time being, CreateDataProperty should translate to
AddProperty/Element.
(plus extra error checking where necessary, of course)
https://codereview.chromium.org/364853009/
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com
CreateDataPropertyOrThrow is new in the ES6 spec, which explains why it
hasn't
occurred in V8 so far. (Likewise, DONT_DELETE predates ES5, which chose to
rename it to (not) configurable, along with renames for the other property
attributes.)
On the other hand, V8 internally distinguished named
On 2014/08/05 02:11:14, caitp wrote:
For what it's worth, if AddElement is in some way a useful implementation
of
CreateDataPropertyOrThrow, we'd have uses for it elsewhere, so the
connection
should be more clearly explained.
This is a valid concern and I also have my doubts. There are curr
Thanks caitp for your comments, I think they are very valid and I also have
doubts. I comment below.
On 2014/08/05 02:09:07, caitp wrote:
I'm not an owner, so take this with a grain of salt:
https://codereview.chromium.org/364853009/diff/260001/src/harmony-array.js
File src/harmony-array.js (
I think the patch is ready to land now. All try bots are green except
'v8_linux_layout_dbg' which seems to be flaky. The bot fails with and
without
the patch. I don't know if there's something on my side I could do to fix
it.
https://codereview.chromium.org/364853009/
--
--
v8-dev mailing l
LGTM, with one nit: please rename array-of-tests.js to just array-of.js, and
move it to the ../harmony directory (which contains tests for all Harmony
features not staged yet).
I provided an implementation for AddElement. It sets an element into an
array
object using the flag DEFINE_PROPERTY. T
On 2014/07/21 16:07:07, rossberg wrote:
Can you please merge all the tests into one file?
Done.
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js#newcode132
Can you please merge all the tests into one file?
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js
File src/harmony-array.js (right):
https://codereview.chromium.org/364853009/diff/60001/src/harmony-array.js#newcode132
src/harmony-array.js:132: var A = new C(len);
Pleas
On 2014/07/16 09:52:15, rossberg wrote:
No, no need to block on that. Just use IS_SPEC_FUNCTION for the time
being,
and
add a suitable TODO.
Included a TODO comment (TODO: Implement IsConstructor (ES6 section
7.2.5)). If
everything is correct, I think the patch should be ready to land.
On 2014/07/14 18:54:33, caitp wrote:
So just a question, are we blocked on filling out the rest of the harmony
standard library additions until we have a proper IsConstructor()
routine? I
feel like these could do to land and fix IsConstructor() later / give
people a
chance to eat the dogfood
https://codereview.chromium.org/364853009/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/364853009/diff/1/src/runtime.cc#newcode7807
src/runtime.cc:7807: RUNTIME_FUNCTION(Runtime_IsConstructor) {
On 2014/07/08 08:39:17, rossberg wrote:
Drive-by-comment: Unfor
https://codereview.chromium.org/364853009/diff/1/src/runtime.cc
File src/runtime.cc (right):
https://codereview.chromium.org/364853009/diff/1/src/runtime.cc#newcode7807
src/runtime.cc:7807: RUNTIME_FUNCTION(Runtime_IsConstructor) {
Drive-by-comment: Unfortunately, I don't think this function is
On 2014/07/07 16:52:09, caitp wrote:
Just one comment, it turns out ---
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-createdatapropertyorthrow
(which defers to
https://people.mozilla.org/~jorendorff/es6-draft.html#sec-createdataproperty)
says that the new property descriptor for t
19 matches
Mail list logo
