[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread adamk
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 10:25:37,

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread rossberg
https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( On 2015/07/21 16:18:08,

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1246933002/20001 https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 2 (id:??) landed as https://crrev.com/4b8200078a9d1d9ec5bab268d0aff6453b47ddcc Cr-Commit-Position: refs/heads/master@{#29779} https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #2 (id:20001) https://codereview.chromium.org/1246933002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Remove unnecessary coupling between Promise tests and Object.observe (issue 1246933002 by ad...@chromium.org)

2015-07-21 Thread rossberg
lgtm https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js File test/mjsunit/es6/promises.js (right): https://codereview.chromium.org/1246933002/diff/1/test/mjsunit/es6/promises.js#newcode90 test/mjsunit/es6/promises.js:90: Promise.resolve().then( Some of the tests