[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread rossberg
On 2015/06/19 12:54:10, wingo wrote: Previously landed in https://codereview.chromium.org/1187173004/, reverted because a layout test did return(); to trigger a devtools behavior, but then matched verbatim on the error, and (); caused a different error after arrow functions were enabled.

[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread rossberg
lgtm https://codereview.chromium.org/1194873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread wingo
On 2015/06/19 13:06:39, rossberg wrote: On 2015/06/19 12:54:10, wingo wrote: Previously landed in https://codereview.chromium.org/1187173004/, reverted because a layout test did return(); to trigger a devtools behavior, but then matched verbatim on the error, and (); caused a different

[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #1 (id:1) https://codereview.chromium.org/1194873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop

[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 1 (id:??) landed as https://crrev.com/9594cc72eec3ad64506c531106dba6c8fc42bae9 Cr-Commit-Position: refs/heads/master@{#29167} https://codereview.chromium.org/1194873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Ship arrow functions (issue 1194873002 by wi...@igalia.com)

2015-06-19 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1194873002/1 https://codereview.chromium.org/1194873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are