[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread jochen
fixed the arm64 crash... the LAddE instruction clamped the pointers to 32bit.. https://codereview.chromium.org/1248483007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups

[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread jarin
Ouch, my eyes! lgtm. https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc#newcode4012 src/heap/heap.cc:4012: kHeapObjectTag), Can't you say

[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread jochen
https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1248483007/diff/20001/src/heap/heap.cc#newcode4012 src/heap/heap.cc:4012: kHeapObjectTag), On 2015/07/22 at 09:00:20, jarin wrote: Can't you say

[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread commit-...@chromium.org via codereview.chromium.org
Patchset 4 (id:??) landed as https://crrev.com/4da289c55acc4fff325d1fbd62387d431a5033d8 Cr-Commit-Position: refs/heads/master@{#29786} https://codereview.chromium.org/1248483007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this

[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread commit-...@chromium.org via codereview.chromium.org
Committed patchset #4 (id:60001) https://codereview.chromium.org/1248483007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and

[v8-dev] Re: Store offset between fixed typed array base and data start in object (issue 1248483007 by joc...@chromium.org)

2015-07-22 Thread commit-...@chromium.org via codereview.chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248483007/60001 https://codereview.chromium.org/1248483007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are