Re: [v8-dev] Build of 5.7-lkgr fails with default options

The fix for this has landed yesterday as https://github.com/v8/v8/commit/6bb221b49ebcac13653477d2d3e01f921a721474. It should work if you just retry. --Clemens On Tue, Feb 28, 2017 at 11:31 AM wrote: > I ran: > > git checkout 5.7-lkgr > gclient sync > make x64.release > >

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

The ObjectBuiltinsAssembler adds a couple of additional helper methods. -- Benedikt Benedikt Meurer | Software Engineer, V8 | Google Germany GmbH | Erika-Mann-Str. 33, 80636 München Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft: Hamburg | Geschäftsführer: Matthew

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

Thank you so much for your hints, I finally get valueOf to work now (was getting crashes in run mksnapshot step before I asked help here)! toString uses ObjectBuiltinsAssembler instead of CodeStubAssembler, what are the differences between them? -- -- v8-dev mailing list

[v8-dev] Re: Contributing to V8

Hi Umang, Great to hear that you're interested in contributing. Your best way to get started is just to get things compiling; V8 is a pretty complex project, and even getting it running can take some time :). You can find information on getting source code and building on our public wiki:

Re: [v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

We don't really have a policy for the builtins, it's good judgement whether to use C++ or CSA. I'd say Object.prototype.valueOf is a good starting point. It can be migrated to a TF_BUILTIN, based on the CodeStubAssembler. The builtin (with JavaScript linkage) would basically become a wrapper for

[v8-dev] Help to migrate JS to C++ (and contributing V8 in general)

Hi all! I am new to V8 project. I am trying to work on crbug.com/v8/6005 (Migrate v8natives.js). By referencing commit history and the style of the codes and lots help from cs.chromium.org/chromium/src/v8/, I at least figured out how to migrate the constants (CL accepted). However, migrating