[v8-dev] Tracing V8

2017-09-05 Thread Weiliang Lin
Hi all I tried to enable v8 to support android systrace on Android device. It looks wonderful that the wiki (https://github.com/v8/v8/wiki/Tracing-V8) told me V8 has already supported tracing for TraceViewer via "--enable-tracing" flag. But the issue is I don't find this flag under v8/src/.

Re: [v8-dev] How to run tests on Android devices?

2017-08-08 Thread Weiliang Lin
Thanks Atiq for your reply. I tried your command but there is still same issue as below $ tools/run-tests.py --arch-and-mode=android_arm.release --outdir=out.gn cctest/test-run-machops/RunInt32Add >>> Running tests for android_arm.release Error executing:

[v8-dev] How to run tests on Android devices?

2017-08-07 Thread Weiliang Lin
Hi After building v8 with GN, I tried to run v8 tests with run-tests.py script on android devices as below tools/run-tests.py --outdir=out.gn/android_arm.release. But it fails to run with the error message "error exec format". It seems to run the test on the host OS rather that the

[v8-dev] Re: X87: Reland Vector ICs: platform support for vector-based stores. (issue 1311413007 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1311413007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [runtime] Remove useless IN builtin. (issue 1325183003 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1325183003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [es6] Initial steps towards a correct implementation of IsCallable. (issue 1310653004 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1310653004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [es6] Re-implement rest parameters via desugaring. (issue 1305943008 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1305943008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: Crankshaft is now able to compile top level code even if there is a ScriptContext. (issue 1308743005 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1308743005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [builtins] Pass correct number of arguments after adapting arguments. (issue 1304893010 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1304893010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: Remove obsolete functionality from the MacroAssemblers. (issue 1321653004 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1321653004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [es6] Introduce a dedicated JSIteratorResult type. (issue 1331523002 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1331523002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: initialize the FPU state for X87 in prologue. (issue 1317643009 by chunyang....@intel.com)

2015-09-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1317643009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [runtime] Add %ToString and %_ToString and remove the TO_STRING builtin. (issue 1326473002 by chunyang....@intel.com)

2015-08-31 Thread weiliang . lin
lgtm https://codereview.chromium.org/1326473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups "v8-dev" group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: [Interpreter] Add support for parameter variables. (issue 1324453003 by chunyang....@intel.com)

2015-08-28 Thread weiliang . lin
lgtm https://codereview.chromium.org/1324453003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Correctify instanceof and make it optimizable. (issue 1318663003 by chunyang....@intel.com)

2015-08-26 Thread weiliang . lin
lgtm https://codereview.chromium.org/1318663003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [interpreter]: Changes to interpreter builtins for accumulator and register file registers. (issue 1304593002 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1304593002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Fix stack-stack double moves for pushing on ia32 and x64. (issue 1286123008 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1286123008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Unify referencing of stack slots (issue 1293103003 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1293103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: VectorICs: New interface descriptor for vector transitioning stores. (issue 1303223002 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1303223002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Cleanup: Remove unncessary leave_frame parameter from stub cache. (issue 1303973004 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1303973004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (issue 1304963003 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1304963003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Support unboxed float and double stack parameters and add tests. (issue 1306833002 by chunyang....@intel.com)

2015-08-21 Thread weiliang . lin
lgtm https://codereview.chromium.org/1306833002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [simd.js] Single SIMD128_VALUE_TYPE for all Simd128Values. (issue 1286313003 by chunyang....@intel.com)

2015-08-18 Thread weiliang . lin
lgtm https://codereview.chromium.org/1286313003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Realize IWYU pattern for frames-inl.h header. (issue 1286143009 by chunyang....@intel.com)

2015-08-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1286143009/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [compiler] Remove broken support for undetectable strings. (issue 1287173002 by chunyang....@intel.com)

2015-08-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1287173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Fix kArchTailCallCodeObject on ia32/x64. (issue 1256163003 by chunyang....@intel.com)

2015-08-02 Thread weiliang . lin
lgtm https://codereview.chromium.org/1256163003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: VectorICs: refactoring to eliminate for queries only vector ic mode. (issue 1265113002 by chunyang....@intel.com)

2015-08-02 Thread weiliang . lin
lgtm https://codereview.chromium.org/1265113002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [interpreter] Change interpreter to use an BytecodeArray pointer and and offset. (issue 1267783002 by chunyang....@intel.com)

2015-07-30 Thread weiliang . lin
lgtm https://codereview.chromium.org/1267783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [interpreter] Add Interpreter{Entry,Exit}Trampoline builtins. (issue 1271433002 by chunyang....@intel.com)

2015-07-30 Thread weiliang . lin
lgtm https://codereview.chromium.org/1271433002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: VectorICs: vector [keyed]store ic MISS handling infrastructure. (issue 1257883003 by chunyang....@intel.com)

2015-07-28 Thread weiliang . lin
lgtm https://codereview.chromium.org/1257883003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [stubs] Don't pass name to Load/StoreGlobalViaContext stubs. (issue 1259063004 by chunyang....@intel.com)

2015-07-28 Thread weiliang . lin
lgtm https://codereview.chromium.org/1259063004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [stubs] Properly handle read-only properties in StoreGlobalViaContextStub. (issue 1263473002 by chunyang....@intel.com)

2015-07-28 Thread weiliang . lin
lgtm https://codereview.chromium.org/1263473002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: implement MathPow stub for X87. (issue 1258873002 by chunyang....@intel.com)

2015-07-27 Thread weiliang . lin
lgtm https://codereview.chromium.org/1258873002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [stubs] Optimize LoadGlobalViaContextStub and StoreGlobalViaContextStub. (issue 1258513003 by chunyang....@intel.com)

2015-07-24 Thread weiliang . lin
lgtm https://codereview.chromium.org/1258513003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: HydrogenCodeStubs consume stack arguments via descriptor. (issue 1258553002 by chunyang....@intel.com)

2015-07-24 Thread weiliang . lin
lgtm https://codereview.chromium.org/1258553002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [interpreter] Add basic framework for bytecode handler code generation. (issue 1256783002 by chunyang....@intel.com)

2015-07-24 Thread weiliang . lin
lgtm https://codereview.chromium.org/1256783002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Unify runtime-style IC functions with Runtime intrinsics (issue 1252903002 by chunyang....@intel.com)

2015-07-24 Thread weiliang . lin
lgtm https://codereview.chromium.org/1252903002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Eliminate redundant descriptor ElementTransitionAndStoreDescriptor. (issue 1253573004 by chunyang....@intel.com)

2015-07-23 Thread weiliang . lin
lgtm https://codereview.chromium.org/1253573004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Fix pushing of register in CallConstructStub outside frame. (issue 1247493004 by chunyang....@intel.com)

2015-07-23 Thread weiliang . lin
lgtm https://codereview.chromium.org/1247493004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Debugger: prepare code for debugging on a per-function basis. (issue 1249503002 by chunyang....@intel.com)

2015-07-20 Thread weiliang . lin
lgtm https://codereview.chromium.org/1249503002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Fix memento initialization when constructing from new call (issue 1229023003 by chunyang....@intel.com)

2015-07-17 Thread weiliang . lin
lgtm https://codereview.chromium.org/1229023003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Switch CallConstructStub to take new.target in register. (issue 1235273003 by chunyang....@intel.com)

2015-07-16 Thread weiliang . lin
lgtm https://codereview.chromium.org/1235273003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Debugger: use debug break slots to break at function exit. (issue 1236023007 by chunyang....@intel.com)

2015-07-16 Thread weiliang . lin
lgtm https://codereview.chromium.org/1236023007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Add an InterpreterDispatch linkage type. (issue 1232383003 by chunyang....@intel.com)

2015-07-14 Thread weiliang . lin
lgtm https://codereview.chromium.org/1232383003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Debugger: record reloc info for debug break slot immediate before the slot. (issue 1228923003 by chunyang....@intel.com)

2015-07-14 Thread weiliang . lin
lgtm https://codereview.chromium.org/1228923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Cleanup Generate_JSConstructStubHelper a bit. (issue 1237013002 by chunyang....@intel.com)

2015-07-14 Thread weiliang . lin
lgtm https://codereview.chromium.org/1237013002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Fix keyed element access wrt string wrappers (issue 1233033004 by chunyang....@intel.com)

2015-07-14 Thread weiliang . lin
lgtm https://codereview.chromium.org/1233033004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Reland: Add unoptimized/optimized variants of MathFloor TF code stub (issue 1235823002 by chunyang....@intel.com)

2015-07-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1235823002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Add TruncationMode for TruncateFloat64ToInt32. (issue 1227923003 by chunyang....@intel.com)

2015-07-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1227923003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Remove separate construct stub for new.target users. (issue 1232833002 by chunyang....@intel.com)

2015-07-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1232833002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Remove separate construct stub for new.target users. (issue 1232833002 by chunyang....@intel.com)

2015-07-13 Thread weiliang . lin
lgtm lgtm https://codereview.chromium.org/1232833002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails

[v8-dev] Re: X87: Debugger: use debug break slot to break on call. (issue 1233823002 by chunyang....@intel.com)

2015-07-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1233823002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Debugger: use debug break slots instead of ICs (except for calls). (issue 1227603002 by chunyang....@intel.com)

2015-07-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1227603002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Enable tail calls for %_CallRuntime. (issue 1228463003 by chunyang....@intel.com)

2015-07-05 Thread weiliang . lin
lgtm https://codereview.chromium.org/1228463003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [ic] Record call counts for monomorphic calls made with an IC. (issue 1213723005 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1213723005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Vector ICs: Like megamorphic keyed koads, use a dummy vector for stores. (issue 1212653011 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1212653011/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: VectorICs: Lithium support for vector-based stores. (issue 1213373002 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1213373002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Unify the stack layout for construct frames. (issue 1219823002 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1219823002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [es6] Make new.target work in functions. (issue 1217083004 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1217083004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Use big-boy Types to annotate interface descriptor parameters. (issue 1210463002 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1210463002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Add basic support for calling to (a subset of) C functions. (issue 1214903007 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1214903007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: change the float max/min operation. (issue 1214893004 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1214893004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [turbofan] Add CalleeSavedFPRegisters to CallDescriptor. (issue 1214573006 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1214573006/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Make context register implicit for CallInterfaceDescriptors (issue 1216543004 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1216543004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [strong] Implement strong property access semantics. (issue 1210873007 by chunyang....@intel.com)

2015-07-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1210873007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Clean up JSConstructStub. (issue 1210153007 by chunyang....@intel.com)

2015-06-30 Thread weiliang . lin
lgtm https://codereview.chromium.org/1210153007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Do not add extra argument for new.target. (issue 1207613003 by chunyang....@intel.com)

2015-06-30 Thread weiliang . lin
lgtm https://codereview.chromium.org/1207613003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Built-in apply() performance benefits from an uninitialized IC. (issue 1199913007 by chunyang....@intel.com)

2015-06-23 Thread weiliang . lin
lgtm https://codereview.chromium.org/1199913007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Vector ICs: Turbofan vector store ic support (issue 1195793007 by chunyang....@intel.com)

2015-06-23 Thread weiliang . lin
lgtm https://codereview.chromium.org/1195793007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-15 Thread weiliang . lin
please run git cl format before uploading patch. https://codereview.chromium.org/1179763004/diff/11/src/compiler/x87/instruction-selector-x87.cc File src/compiler/x87/instruction-selector-x87.cc (right):

[v8-dev] Re: X87: enable the X87 turbofan support. (issue 1179763004 by chunyang....@intel.com)

2015-06-15 Thread weiliang . lin
LGTM, but CL still needs LGTM from V8 team. @danno, @Titzer Thanks -Weiliang https://codereview.chromium.org/1179763004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev

[v8-dev] Re: X87: Refactor lexical home object binding. (issue 1173933005 by chunyang....@intel.com)

2015-06-11 Thread weiliang . lin
lgtm https://codereview.chromium.org/1173933005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Vector ICs: debugger should save registers for vector store ics. (issue 1173963002 by chunyang....@intel.com)

2015-06-11 Thread weiliang . lin
lgtm https://codereview.chromium.org/1173963002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [date] Refactor the %_DateField intrinsic to be optimizable. (issue 1174913002 by chunyang....@intel.com)

2015-06-11 Thread weiliang . lin
lgtm https://codereview.chromium.org/1174913002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Vector ICs: ClassLiterals need to allocate a vector slot for home objects. (issue 1178533002 by chunyang....@intel.com)

2015-06-11 Thread weiliang . lin
lgtm https://codereview.chromium.org/1178533002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [strong] Refactor ObjectStrength into a replacement for strong boolean args (issue 1173973002 by chunyang....@intel.com)

2015-06-11 Thread weiliang . lin
lgtm https://codereview.chromium.org/1173973002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [es6] Super call in arrows and eval (issue 1163983002 by chunyang....@intel.com)

2015-06-10 Thread weiliang . lin
lgtm https://codereview.chromium.org/1163983002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Build ObjectLiteral constant properties in the numbering phase. (issue 1168563003 by chunyang....@intel.com)

2015-06-10 Thread weiliang . lin
lgtm https://codereview.chromium.org/1168563003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Make RawMachineAssemblerTest always have a dummy End block (issue 1166293004 by weiliang....@intel.com)

2015-06-10 Thread weiliang . lin
Reviewers: Sven Panne, Michael Starzinger, danno, Message: PTAL Description: Make RawMachineAssemblerTest always have a dummy End block Frame Elider requires a sane CFG which should such dummy end block. BUG= Please review this at https://codereview.chromium.org/1166293004/ Base URL:

[v8-dev] Re: X87: [turbofan] First step towards sanitizing for-in and making it optimizable. (issue 1144143005 by chunyang....@intel.com)

2015-06-02 Thread weiliang . lin
lgtm https://codereview.chromium.org/1144143005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Move hash code from hidden string to a private symbol (issue 1153963010 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1153963010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [es6] Support super.property in eval and arrow functions (issue 1158543004 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1158543004/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Move work to omit unnecessary ObjectLiteral stores to the numbering pass. (issue 1165693002 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1165693002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Make KeyedStores from a sloppy arguments array use a handler. (issue 1163603003 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1163603003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [crankshaft] Record inlined shared function infos instead of closures. (issue 1143003003 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1143003003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: VectorICs: allocating slots for store ics in ast nodes. (issue 1155383003 by chunyang....@intel.com)

2015-06-01 Thread weiliang . lin
lgtm https://codereview.chromium.org/1155383003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [es6] Spread in array literals (issue 1152173002 by chunyang....@intel.com)

2015-05-25 Thread weiliang . lin
lgtm https://codereview.chromium.org/1152173002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Vector ICs: Introduce Store and KeyedStore IC code stubs. (issue 1148963003 by chunyang....@intel.com)

2015-05-25 Thread weiliang . lin
lgtm https://codereview.chromium.org/1148963003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Cleanup interface descriptors to reflect that vectors are part of loads. (issue 1152473003 by chunyang....@intel.com)

2015-05-20 Thread weiliang . lin
lgtm https://codereview.chromium.org/1152473003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [strong] Function arity check should be based on required parameters (issue 1146103003 by chunyang....@intel.com)

2015-05-20 Thread weiliang . lin
lgtm https://codereview.chromium.org/1146103003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code … (issue 1142713007 by chunyang....@intel.com)

2015-05-19 Thread weiliang . lin
lgtm https://codereview.chromium.org/1142713007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Reapply Resolve references to this the same way as normal variables (issue 1135233003 by chunyang....@intel.com)

2015-05-19 Thread weiliang . lin
lgtm https://codereview.chromium.org/1135233003/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert X87: Resolve references to this the same way as normal variables (issue 1130853007 by chunyang....@intel.com)

2015-05-14 Thread weiliang . lin
lgtm https://codereview.chromium.org/1130853007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Add a MathFloor stub generated with TurboFan (issue 1134323002 by chunyang....@intel.com)

2015-05-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1134323002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: [strong] Check arity of functions (issue 1139913007 by chunyang....@intel.com)

2015-05-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1139913007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Resolve references to this the same way as normal variables (issue 1136953010 by chunyang....@intel.com)

2015-05-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1136953010/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: New hydrogen instruction to reduce cost of growing an array on keyed stores. (issue 1124093008 by chunyang....@intel.com)

2015-05-13 Thread weiliang . lin
lgtm https://codereview.chromium.org/1124093008/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: Revert of X87: Resolve references to this the same way as normal variables (issue 1130913005 by chunyang....@intel.com)

2015-05-07 Thread weiliang . lin
lgtm https://codereview.chromium.org/1130913005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Resolve references to this the same way as normal variables (issue 1124393002 by chunyang....@intel.com)

2015-05-06 Thread weiliang . lin
lgtm https://codereview.chromium.org/1124393002/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

[v8-dev] Re: X87: Optimize the typeof operator. (issue 1124263005 by chunyang....@intel.com)

2015-05-06 Thread weiliang . lin
lgtm https://codereview.chromium.org/1124263005/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from this group and stop receiving emails from

  1   2   3   4   5   6   >