[v8-dev] Re: [turbofan] add gap move verifier (issue 704193007 by dcar...@chromium.org)

2014-11-12 Thread jarin
Very cool stuff. I have bunch of comments and questions. https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc#newcode579

[v8-dev] Re: [turbofan] add gap move verifier (issue 704193007 by dcar...@chromium.org)

2014-11-12 Thread dcarney
https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc File src/compiler/pipeline.cc (right): https://codereview.chromium.org/704193007/diff/260001/src/compiler/pipeline.cc#newcode579 src/compiler/pipeline.cc:579: RegisterAllocatorVerifier* verifier = NULL; On 2014/11/12

[v8-dev] Re: [turbofan] add gap move verifier (issue 704193007 by dcar...@chromium.org)

2014-11-12 Thread dcarney
added second pass - cleaned some stuff up - ptal https://codereview.chromium.org/704193007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev group. To unsubscribe from

[v8-dev] Re: [turbofan] add gap move verifier (issue 704193007 by dcar...@chromium.org)

2014-11-12 Thread jarin
lgtm. https://codereview.chromium.org/704193007/diff/380001/src/compiler/register-allocator-verifier.cc File src/compiler/register-allocator-verifier.cc (right): https://codereview.chromium.org/704193007/diff/380001/src/compiler/register-allocator-verifier.cc#newcode390

[v8-dev] Re: [turbofan] add gap move verifier (issue 704193007 by dcar...@chromium.org)

2014-11-12 Thread dcarney
Committed patchset #20 (id:380001) manually as 25300 (presubmit successful). https://codereview.chromium.org/704193007/ -- -- v8-dev mailing list v8-dev@googlegroups.com http://groups.google.com/group/v8-dev --- You received this message because you are subscribed to the Google Groups v8-dev