Reviewers: ulan,
Message:
Could you a take a look please?
Any idea how to test this? The only repro I have is an html page that
ASSERTs in
release mode with heap verification (I am not even sure we run this
configuration on the waterfall).
Description:
Zap prototype transitions in release mode, too.
R=u...@chromium.org
BUG=431559
LOG=n
Please review this at https://codereview.chromium.org/715233002/
Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -3 lines):
M src/objects-inl.h
Index: src/objects-inl.h
diff --git a/src/objects-inl.h b/src/objects-inl.h
index
e7dcd631a85eadf901eb9c36659d067e49f81998..55b88301b1a1b4b809ac42370d93196366ffd38b
100644
--- a/src/objects-inl.h
+++ b/src/objects-inl.h
@@ -5368,12 +5368,10 @@ void Map::SetPrototypeTransitions(
Handle<Map> map, Handle<FixedArray> proto_transitions) {
EnsureHasTransitionArray(map);
int old_number_of_transitions = map->NumberOfProtoTransitions();
-#ifdef DEBUG
- if (map->HasPrototypeTransitions()) {
+ if (Heap::ShouldZapGarbage() && map->HasPrototypeTransitions()) {
DCHECK(map->GetPrototypeTransitions() != *proto_transitions);
map->ZapPrototypeTransitions();
}
-#endif
map->transitions()->SetPrototypeTransitions(*proto_transitions);
map->SetNumberOfProtoTransitions(old_number_of_transitions);
}
--
--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to v8-dev+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
