[v8-dev] Pinpoint should also "auto-blame" improvements down a single CL

2018-02-19 Thread 'Gabriel Charette' via v8-dev
Hello Benchmarking Dev! First, thanks for your hard work on bringing and keeping reliable benchmarks with automatic single CL blaming tools. I recently have been digging more into low-level scheduling primitives on the v8 side and it tends to move benchmarks in interesting ways. *The problem:* p

[v8-dev] Re: Pinpoint should also "auto-blame" improvements down a single CL

2018-02-20 Thread 'Gabriel Charette' via v8-dev
Thanks for routing correctly :) I did notice that it pins a black dot on regressions and a green dot on improvements. But I never got a notification about the green dots (nor on causal CL, nor on crbug, nor over email as CL author). Nor do I see on the graphs that it's been pinpointed to a single

[v8-dev] Re: Pinpoint should also "auto-blame" improvements down a single CL

2018-02-20 Thread 'Gabriel Charette' via v8-dev
Oops, we crossed in writing :) On Tue, Feb 20, 2018 at 5:37 PM wrote: > Completely agree in that we want to get to a place where you can clearly > what impact a CL had. The data and tooling are getting there, there's been > considerable effort in the last year to improve things on that front. We