Re: [v8-dev] When to use which macro for component builds

2016-10-18 Thread Jochen Eisinger
On Mon, Oct 17, 2016 at 11:39 PM Adam Klein wrote: > On Mon, Oct 17, 2016 at 8:18 AM, Jochen Eisinger > wrote: > > > > On Fri, Oct 14, 2016 at 8:19 PM Adam Klein wrote: > > I take it from your omission that code which isn't accessed anywhere but > within src doesn't need any export macro? > > >

Re: [v8-dev] When to use which macro for component builds

2016-10-17 Thread Adam Klein
On Mon, Oct 17, 2016 at 8:18 AM, Jochen Eisinger wrote: > > > On Fri, Oct 14, 2016 at 8:19 PM Adam Klein wrote: > >> I take it from your omission that code which isn't accessed anywhere but >> within src doesn't need any export macro? >> > > well, within the same compilation unit. > > If src/d8.

Re: [v8-dev] When to use which macro for component builds

2016-10-17 Thread Jochen Eisinger
On Fri, Oct 14, 2016 at 8:19 PM Adam Klein wrote: > I take it from your omission that code which isn't accessed anywhere but > within src doesn't need any export macro? > well, within the same compilation unit. If src/d8.cc access something in src/factory.h the latter needs to be exported. (d8.

Re: [v8-dev] When to use which macro for component builds

2016-10-14 Thread Adam Klein
I take it from your omission that code which isn't accessed anywhere but within src doesn't need any export macro? On Fri, Oct 14, 2016 at 6:47 AM, Jochen Eisinger wrote: > Hey, > > we recently started to support component builds for almost all binaries. > With this, it might happen that debug b