Re: [v8-users] Attempting to understand the performance issue with this method, as well as it's corresponding v8 depot messages

2018-09-25 Thread caitp
Oop, re-reading that, I realize that was unclear --- The compiler deopts because operations in those rare branches haven't been run yet, so there is no type feedback and the compiler doesn't know what to do with them. So, v8 deopts, and resumes execution from the slow path, which collects that

Re: [v8-users] Attempting to understand the performance issue with this method, as well as it's corresponding v8 depot messages

2018-09-25 Thread caitp
Sounds like a cool project :) So, I think these deopts are all expected, and I don't think you're in a deopt loop (but I could be wrong about that). Basically what's happening is, your `tick()` function is called frequently, you increment counters (dot count, scanline count, instruction cycle

[v8-users] Attempting to understand the performance issue with this method, as well as it's corresponding v8 depot messages

2018-09-25 Thread Taylor Dondich
I'm building a NES emulator in Javascript and there's a certain function of code that when gathering performance metrics in google chrome, shows that the self time for this method is over 30% of overall execution time. That's pretty excessive to what looks like a tree of if/else statements. I

Re: [v8-users] What are the threading considerations for EmbedderHeapTracer?

2018-09-25 Thread 'Kenton Varda' via v8-users
Hi Michael, Thanks for commenting! On Tue, Sep 25, 2018 at 6:37 AM Michael Lippautz wrote: > Looks like Isolate::VisitWeakHandles > > only iterates over weak handles with a non-zero class

Re: [v8-dev] Re: [v8-users] Re: Intent to ship: Intl.RelativeTimeFormat

2018-09-25 Thread 'Mathias Bynens' via v8-users
LGTM3 On Tue, Sep 25, 2018 at 10:46 AM Adam Klein wrote: > LGTM2 > > On Tue, Sep 25, 2018 at 2:35 AM Sathya Gunasekaran > wrote: > >> LGTM >> >> On Mon, Sep 24, 2018 at 5:35 PM Frank Tang wrote: >> >>> Spec >>> >>> https://tc39.github.io/proposal-intl-relative-time/ >>> >>> Summary >>> >>> A

Re: [v8-users] Re: Intent to ship: Intl.RelativeTimeFormat

2018-09-25 Thread Adam Klein
LGTM2 On Tue, Sep 25, 2018 at 2:35 AM Sathya Gunasekaran wrote: > LGTM > > On Mon, Sep 24, 2018 at 5:35 PM Frank Tang wrote: > >> Spec >> >> https://tc39.github.io/proposal-intl-relative-time/ >> >> Summary >> >> A Stage 3 proposal that introduces a new formatter under Intl. >> >>

Re: [v8-users] What are the threading considerations for EmbedderHeapTracer?

2018-09-25 Thread Michael Lippautz
On Sun, Sep 23, 2018 at 7:54 PM 'Kenton Varda' via v8-users < v8-users@googlegroups.com> wrote: > Hi v8-users, > > I'm trying to understand how to correctly instrument my wrappers for > multi-threaded garbage collection, and it seems I'm doing something wrong. > Currently, my code seems to work

[v8-users] Re: Intent to ship: Intl.RelativeTimeFormat

2018-09-25 Thread Sathya Gunasekaran
LGTM On Mon, Sep 24, 2018 at 5:35 PM Frank Tang wrote: > Spec > > https://tc39.github.io/proposal-intl-relative-time/ > > Summary > > A Stage 3 proposal that introduces a new formatter under Intl. > > Intl.RelativeTimeFormat is a low level API to facilitate libraries and > frameworks to format