[v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-08 Thread Yutaka Hirano
> As to the problem itself, I have a clarifying questions: doesn't Blink already have some choke point to determine whether it's "ok to call script now"? If so that'd be a more natural place to add this handling than TryCatch. No, there isn't such a point. To make matters worse, some call-sites

[v8-users] objdump with d8?

2018-11-08 Thread TLim
Hi, I'm trying to retrieve the instruction pointer information when I run a d8 with JS program. For example, $v8/out.gn/x64_release/d8 foo.js. I realize that there is a tool 'objdump_v8' in the v8/tools folder. If anyone can help me how can I use the objdump with d8 or any other method

[v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-08 Thread Adam Klein
Adding a couple more V8 folks who may have thoughts. On Thu, Nov 8, 2018 at 1:59 AM Kentaro Hara wrote: > On Thu, Nov 8, 2018 at 1:10 AM Yuki Shiino > wrote: > >> +adamk, cbruni to get more attention from V8 team. This needs V8 team's >> support. >> >> Actually, I intended haraken's (a3) at

[v8-users] Re: [blink-dev] Re: [v8-dev] Re: Intent to ship: Intl.ListFormat

2018-11-08 Thread Adam Klein
LGTM3 On Thu, Nov 8, 2018 at 9:16 AM 'Mathias Bynens' via blink-dev < blink-...@chromium.org> wrote: > LGTM2 > > On Thu, Nov 8, 2018 at 2:44 AM Sathya Gunasekaran > wrote: > >> LGTM >> >> On Thu, Nov 8, 2018 at 12:20 AM Frank Tang wrote: >> >>> Spec >>> >>>

[v8-users] Re: [v8-dev] Re: Intent to ship: Intl.ListFormat

2018-11-08 Thread 'Mathias Bynens' via v8-users
LGTM2 On Thu, Nov 8, 2018 at 2:44 AM Sathya Gunasekaran wrote: > LGTM > > On Thu, Nov 8, 2018 at 12:20 AM Frank Tang wrote: > >> Spec >> >> https://tc39.github.io/proposal-intl-list-format >> >> Summary >> >> A Stage 3 proposal that introduces a new formatter under Intl. >> >> Intl.ListFormat

[v8-users] Re: Intent to ship: Intl.ListFormat

2018-11-08 Thread Sathya Gunasekaran
LGTM On Thu, Nov 8, 2018 at 12:20 AM Frank Tang wrote: > Spec > > https://tc39.github.io/proposal-intl-list-format > > Summary > > A Stage 3 proposal that introduces a new formatter under Intl. > > Intl.ListFormat helps libraries and frameworks format a list in a > localized fashion by

Re: [v8-users] Re: visual studio debug v8 problems

2018-11-08 Thread Clemens Hammacher
You can do the equivalent to the "jlh" gdb macro: https://cs.chromium.org/chromium/src/v8/tools/gdbinit?l=16 In your case: _v8_internal_Print_Object(*((v8::internal::Object**)source.val_)) On Tue, Nov 6, 2018 at 4:07 AM Early wrote: > Any helps, thanks > > > On Thursday, November 1, 2018 at

[v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-08 Thread Kentaro Hara
On Thu, Nov 8, 2018 at 1:10 AM Yuki Shiino wrote: > +adamk, cbruni to get more attention from V8 team. This needs V8 team's > support. > > Actually, I intended haraken's (a3) at my proposal (a), but I'm afraid > that changing an existing API HasCaught() would break backward > compatibility.

[v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-08 Thread Yuki Shiino
+adamk, cbruni to get more attention from V8 team. This needs V8 team's support. Actually, I intended haraken's (a3) at my proposal (a), but I'm afraid that changing an existing API HasCaught() would break backward compatibility. So, I'm also proposing to add a new V8 API like

[v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-08 Thread Kentaro Hara
Thanks, I got it :) My proposal would be: (a3) Make HasCaught() return true when the isolate is terminated. I'm not sure if (a) or (a2) is a good idea because the fact that we didn't call ReThrow() means that we (intentionally) suppressed the exception. Thoughts? On Wed, Nov 7, 2018 at 9:51