[v8-users] Returning v8::MaybeLocal from C++ functions

2018-11-22 Thread Gautham B A
Hi all, I was wondering if it's alright to just return a *v8::MaybeLocal* from a C++ function. We know that* v8::Local* objects must be escaped using a *v8::EscapableHandleScope* if we are to return v8::Local from a function. But I couldn't find the corresponding *Escape()* overload for

[v8-users] Branch cut V8 7.2

2018-11-22 Thread Michael Hablich
Hi, it is time again. If you have any questions regarding the release, please ping this thread. THURSDAY 2018-11-22: API adoption freeze starting V8 will branch in one week for the upcoming Beta phase for Chrome 72. On the 2018-11-29 one of the latest Canaries will be selected to be the branch

Re: [v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-22 Thread Yuki Shiino
> > What you could do is add a check after E1 for >> v8::TryCatch::HasTerminated(), and schedule another >> Isolate::TerminateExecution() if true. You would need to do this for E2 as >> well, if you expect an E3, and so forth. >> > That might be possible by migrating >

Re: [v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-22 Thread Yutaka Hirano
On Thu, Nov 22, 2018 at 8:53 AM Kentaro Hara wrote: > Would it be hard to make Blink immediately terminate the worker thread > after E1 is forcibly terminated? > > Blink is already doing that for common script execution paths e.g., event > listeners, call functions etc. > Script execution is

Re: [v8-users] Re: How to rescue issues caused by v8::Isolate termination

2018-11-22 Thread Yang Guo
I could change V8 to not clear the termination exception so that we always stay in the terminated mode and not recover. However, from experience I expect tons of tests to fail if I implemented this change. What you could do is add a check after E1 for v8::TryCatch::HasTerminated(), and schedule