My suggested fix there doesn't seem to work MSVC non-component builds so
probably won't work for component builds either. I think
https://chromium-review.googlesource.com/c/v8/v8/+/1918249 should work.
On Fri, 15 Nov 2019 at 15:05, Dan Elphick wrote:
> No worries. You're finding real bugs which
No worries. You're finding real bugs which clang/gcc which don't show up
with clang/gcc because of the way they do dll import/exports.
In this case there's a missing inline keyword at:
https://cs.chromium.org/chromium/src/v8/src/objects/hash-table.h?sq=package:chromium=0=150
It should be:
static
Dan,
I resynced with your landed changes, and reverted 7186b6 as you suggested.
I encounter the error message below. As ever, I appreciate your ongoing
correspondence, I am sure it must be a painful process.
Ben
[exec] FAILED: obj/d8/async-hooks-wrapper.obj
[exec] ninja -t msvc -e
