Re: [v8-users] Re: CpuProfiler sampling and multiple threads

No worries, Rubberducking is quite efficient sometimes! ;) Feel free to send a pull request and we can have a look at it! cheers, Camillo On Mon, 3 Aug 2020 at 13:58, Alex Kodat wrote: > OK, now I'm replying to myself a second time. Really sorry. I realized we

Re: [v8-users] Re: CpuProfiler sampling and multiple threads

Yes, a (small?) CL to get sampling on Windows to parity with how it's already working on Linux sounds good. (I'm not familiar with the specifics of how sampling works or should work.) On Mon, Aug 3, 2020 at 1:58 PM Alex Kodat wrote: > OK, now I'm replying to myself a second time. Really

[v8-users] Re: CpuProfiler sampling and multiple threads

OK, now I'm replying to myself a second time. Really sorry. I realized we don't need any enhancement to sampling other than getting the non-check for Isolate locked by debugged (suspended) thread fixed in Windows. For sampling when Isolate is unlocked I can simply get time before and after an