Re: [v8-users] How can I resolve or workaround this undefined symbol, building V8 on Windows 10, MSVC++2017?

2019-11-03 Thread Ben Ernst
Thank you Jakob for your advice. For the record, for anyone stumbling across this thread, I changed ingredient (1), and built just targets "v8", "v8_base" and "v8_platform" by passing those arguments to Ninja. Ben On Thursday, 31 October 2019 00:39:15 UTC+10:30, Jakob Kummerow wrote: > > If I

Re: [v8-users] How can I resolve or workaround this undefined symbol, building V8 on Windows 10, MSVC++2017?

2019-10-30 Thread Jakob Kummerow
If I had to guess: unibrow::ToUppercase::Convert in src/strings/unicode.h needs a V8_EXPORT_PRIVATE annotation in order to support the specific combination of building (1) cctests (2) on Windows (3) with is_component_build = true and (4) with v8_enable_i18n_support = false. If that theory is

[v8-users] How can I resolve or workaround this undefined symbol, building V8 on Windows 10, MSVC++2017?

2019-10-30 Thread Ben Ernst
I am building V8 7.8 (Windows 10, MSVC++ 2017) . My arguments to "GN" are as follows: treat_warnings_as_errors=false is_component_build=true v8_enable_i18n_support=false v8_use_snapshot=true I invoke ninja as follows. ninja -C out.gn/x64.release I encounter the below error toward the end of