Re: [v8-users] How do compile the code coverage for V8?

2018-09-17 Thread hikai . bep
Thank you for your patch. 2018년 9월 17일 월요일 오후 5시 11분 51초 UTC+9, Clemens Hammacher 님의 말: > > This is fixed on ToT via https://crrev.com/c/1206291. > > On Sat, Sep 15, 2018 at 4:37 PM > wrote: > > So I solved it but environment is Ubuntu 18.04 with gcc-7.3.0. > However, always occurred warnings. >

Re: [v8-users] How do compile the code coverage for V8?

2018-09-17 Thread Clemens Hammacher
This is fixed on ToT via https://crrev.com/c/1206291. On Sat, Sep 15, 2018 at 4:37 PM wrote: > So I solved it but environment is Ubuntu 18.04 with gcc-7.3.0. > However, always occurred warnings. > > My CLI is here: > gn args test/ --args='target_cpu="x64" v8_target_cpu="arm64" is_debug=true >

Re: [v8-users] How do compile the code coverage for V8?

2018-09-15 Thread hikai . bep
So I solved it but environment is Ubuntu 18.04 with gcc-7.3.0. However, always occurred warnings. My CLI is here: gn args test/ --args='target_cpu="x64" v8_target_cpu="arm64" is_debug=true v8_code_coverage=true is_clang=false v8_optimized_debug=false treat_warnings_as_errors=false' And

Re: [v8-users] How do compile the code coverage for V8?

2018-09-05 Thread hikai . bep
I first tried to build using Ubuntu 16.04 latest gcc version. (I don't remember the details, but I probably remember the version 6.0) However, when tested in the latest gcc based on the same args, the following linker error occurred: python "../../build/toolchain/gcc_solink_wrapper.py"

Re: [v8-users] How do compile the code coverage for V8?

2018-09-05 Thread Clemens Hammacher
It seems like this warning ("class-memaccess") was introduces in gcc 8.0, which we do not test currently. Can you try compiling with an older gcc version? On Tue, Sep 4, 2018 at 4:14 AM wrote: > Hello > I create gn files with args. > > gn args test/ --args='target_cpu="x64"

[v8-users] How do compile the code coverage for V8?

2018-09-03 Thread hikai . bep
Hello I create gn files with args. gn args test/ --args='target_cpu="x64" v8_target_cpu="arm64" is_debug=true v8_code_coverage=true is_clang=false v8_optimized_debug=false' And I tried compile with gcc 8.1.0 in Ubuntu 16.04 but occured errors. --- hikai@ubuntu:~/wrap_v8/v8/out.gn$ ninja -C