Thanks for the information about the stubs and using value() rather than
NULL.
Unfortunately I'm still have a problem where v8 crashes when I my pass
runs. To help debug the problem I tried printing out the instruction in my
pass (without removing them) and I was still getting a crash that seemed
Don't touch stubs, they're not what you're interested in.
Regarding your original question, try replacing an HCheckMaps instruction
with its value() rather than NULL.
On Wed, Nov 5, 2014 at 6:39 PM, Gabriel Southern
wrote:
>
> On Wed, Nov 5, 2014 at 9:03 AM, Vyacheslav Egorov
> wrote:
>
>> Hy
On Wed, Nov 5, 2014 at 9:03 AM, Vyacheslav Egorov
wrote:
> Hydrogen is also used to generate stubs and there CheckMaps "deopt" has a
> different semantics from a normal deopt - and it is not reported in
> --trace-deopt (which reports all normal JS function deopts). You have to
> accommodate for
Hydrogen is also used to generate stubs and there CheckMaps "deopt" has a
different semantics from a normal deopt - and it is not reported in
--trace-deopt (which reports all normal JS function deopts). You have to
accommodate for that in your experiments.
I however think that your experiment doe
Perhaps it would help if I explained my motivation. I'm trying to evaluate
the overhead of conditional deoptimization checks. One way is by running
workloads that have the checks in their normal configuration and measuring
the runtime. Then removing checks that were never triggered and rerunn
Removing check instructions is so utterly wrong and dangerous that I can't
bring myself to even try to help you. Just don't do it!
On Wed, Nov 5, 2014 at 8:19 AM, Gabriel Southern
wrote:
> I'm experimenting with removing deoptimization checks and I have a
> question about how to remove hydrogen
I'm experimenting with removing deoptimization checks and I have a question
about how to remove hydrogen instructions.
I'm looking at a benchmark where the CheckMaps deoptimization checks are
never triggered and I'm trying to remove them. I know this is not safe in
the general case, but when I
