Re: [v8-users] Re: Memory Leak in `v8::Isolate::New(v8::Isolate::CreateParams const&)`

2020-06-19 Thread Dan Elphick
I've attempted to reproduce with your sample code and I can't get it to work. I modified samples/hello-world.cc and changed main to this: int main(int argc, char* argv[]) { std::unique_ptr platform = v8::platform::NewDefaultPlatform(); v8::V8::InitializePlatform(platform.get());

Re: [v8-users] Re: Memory Leak in `v8::Isolate::New(v8::Isolate::CreateParams const&)`

2020-06-17 Thread Immanuel Haffner
Hey Dan, thanks for the quick reply. I figured that this is related to pointer compression. I *enabled* pointer compression and the leak is gone. Regards, Immanuel delp...@chromium.org schrieb am Mittwoch, 17. Juni 2020 um 15:03:25 UTC+2: > Thanks for the report. This may be a bogus report

Re: [v8-users] Re: Memory Leak in `v8::Isolate::New(v8::Isolate::CreateParams const&)`

2020-06-17 Thread Dan Elphick
Thanks for the report. This may be a bogus report (in that the memory isn't actually leaked) because we use mmap to allocate our memory for MemoryChunks, which means LeakSanitiser doesn't see that there is a connection to the memory pointed to by the MemoryChunk. Alternatively I've created a real

[v8-users] Re: Memory Leak in `v8::Isolate::New(v8::Isolate::CreateParams const&)`

2020-06-17 Thread Immanuel Haffner
I create an instance with v8::Isolate::CreateParams create_params; create_params.array_buffer_allocator = allocator_ = v8::ArrayBuffer::Allocator::NewDefaultAllocator(); isolate_ = v8::Isolate::New(create_params); and dispose of it with isolate_->Dispose(); delete

[v8-users] Re: Memory Leak in `v8::Isolate::New(v8::Isolate::CreateParams const&)`

2020-06-17 Thread Immanuel Haffner
Build args are is_clang=true is_component_build=false v8_monolithic=true v8_enable_pointer_compression=false treat_warnings_as_errors=false v8_use_external_startup_data=false use_sysroot=false use_custom_libcxx=false clang_use_chrome_plugins=false target_cpu="x64" is_debug=true