Re: [v8-users] Re: Upgrading v8 from 7.4 to 8.5

2020-11-03 Thread Ben Noordhuis
On Tue, Nov 3, 2020 at 9:56 AM Vinayaka Kamath wrote: > While upgrading the v8 version -- I have replaced > platform->CallOnForegroundThread with platform->CallOnWorkerThread. Could > the "Fatal error in HandleScope::HandleScope # Entering the V8 API without > proper locking in place" happen b

Re: [v8-users] Re: Upgrading v8 from 7.4 to 8.5

2020-11-03 Thread Vinayaka Kamath
Hello, While upgrading the v8 version -- I have replaced *platform->CallOnForegroundThread * with *platform->CallOnWorkerThread. *Could the "Fatal error in HandleScope::HandleScope # Entering the V8 API without proper locking in place" happen because of that? Thanks On Tuesday, November 3, 202

Re: [v8-users] Re: Upgrading v8 from 7.4 to 8.5

2020-11-03 Thread Vinayaka Kamath
Hello Ben, But I don't have an HandleScopes in my code -- neither in my InspectorClient nor in my agent. The error seems to be getting raised from v8::Utils::ApiCheck(). Do I need to set some flags in any of the changed function prototypes in the new v8 version? or does any of the new functions

Re: [v8-users] Re: Upgrading v8 from 7.4 to 8.5

2020-11-02 Thread Ben Ernst
Vinayaka, the answer is here in your console output. # Fatal error in HandleScope::HandleScope # Entering the V8 API without proper locking in place # You want to use v8::Locker consistently, pretty much wherever you have a HandleScope you need to instantiate a v8::Locker immediately before. Reg

[v8-users] Re: Upgrading v8 from 7.4 to 8.5

2020-11-02 Thread Vinayaka Kamath
I have attached the stack trace from attaching the debugger to the running program below: https://drive.google.com/drive/folders/124iiIB682-vgbN5S0BPG2mR2DmUe32lc?usp=sharing On Tuesday, November 3, 2020 at 10:49:21 AM UTC+5:30 Vinayaka Kamath wrote: > Hello All, > > I am involved with a project