Re: [v8-users] Re: v8 protocol not progressing after id:8

2017-06-17 Thread Zac Hansen
Oh. I didn't realize you were still on the old Api. On Sat, Jun 17, 2017 at 10:32 AM Harsha HS wrote: > Hi, > > Looks like v8-inspector APIs have changed between v8 verison 5.5 and v8 > version 5.9. I am trying to port my changes to 5.9 similar to what node has > done

Re: [v8-users] Re: v8 protocol not progressing after id:8

2017-06-17 Thread Harsha HS
Hi, Looks like v8-inspector APIs have changed between v8 verison 5.5 and v8 version 5.9. I am trying to port my changes to 5.9 similar to what node has done in their master or 8.x branch -Harsha On Sat, Jun 17, 2017 at 3:11 AM, Zac Hansen wrote: > did you ever figure this

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-16 Thread Zac Hansen
did you ever figure this out? I'm working with very similar parts of v8 right now and am quite interested in what you may have learned. Thanks. --Zac On Wednesday, June 7, 2017 at 8:31:13 PM UTC-7, Zac Hansen wrote: > > Your understanding of this is either wrong or correct and way beyond my

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
Your understanding of this is either wrong or correct and way beyond my comprehension -- and I have no way of knowing which. Your function says: // This function can be reentered if there was an incoming message while // V8 was processing another inspector request (e.g. if the user is //

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Harsha HS
Hi, I am calling dispatchMessageFromFrontend at https://github.com/hsharsha/v8inspector/blob/a8219beb1b69ae6cbec1c79274291a14910cc248/inspector_agent.cc#L680 in DispatchMessages function. Frontend is the message I receive from websocket. I am having an incoming_meesage_queue which queues the

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
Sorry if I'm bothering you or not helping, but... Where are you calling your dispatchMessageFromFrontend from? Maybe I'm searching poorly again, but I dont' see a call. Sending the message received from your websocket to that call is what, by my limited understanding, is what takes care of

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
That's odd. I don't have any such call and everything works fine for me -- in the code I linked to above. Though I'm not exactly sure what you mean by "frontend" and "backend" in this case. When javascript is paused, it's not supposed to be doing anything except processing messages from the

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Harsha HS
It does not work if I do not call PumpMessageLoop in the pause loop. This is needed to push message from frontend to the backend. If I comment this out, inspector will pause when hit on halt but does not respond to any other front end messages. On Wednesday, June 7, 2017 at 1:21:11 PM

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
I'm not sure what the PumpMessageLoop call does, but have you tried it without? That sounds like it might start execution of code even though it is supposed to be paused. On Tuesday, June 6, 2017 at 11:11:20 PM UTC-7, Zac Hansen wrote: > > Hrmm, not sure what happened, I search now and I

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
Hrmm, not sure what happened, I search now and I see this: https://github.com/hsharsha/v8inspector/blob/a8219beb1b69ae6cbec1c79274291a14910cc248/inspector_agent.cc#L308 On Tuesday, June 6, 2017 at 11:08:52 PM UTC-7, Zac Hansen wrote: > > I searched your code for runMessageLoopOnPause and didn't

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-07 Thread Zac Hansen
I searched your code for runMessageLoopOnPause and didn't find an override in your subclass. I'm no expert, but the code that I have that works is: https://github.com/xaxxon/v8toolkit/blob/9770d167bc6c39ee731fa10ff082267f250c53ab/include/debugger.h#L286 virtual void

[v8-users] Re: v8 protocol not progressing after id:8

2017-06-06 Thread Harsha HS
Having trouble when those are hit. I am able to set breakpoints I am processing messages in the pause loop. I can watch and respond to getProperty methods when paused. But only way to pause in my code is by hitting halt on the dev-tools. Any other action like step, will just continue the JS

[v8-users] Re: v8 protocol not progressing after id:8

2017-05-28 Thread Anoop R. S.
Hi Harsha, Is it setting the breakpoints by passing "method":"Debugger.setBreakpointByUrl" ? Seems like it is having problems on pausing: pausing at a breakpoint, pausing after singlestep operation. runMessageLoopOnPause function is called when debugger pauses (at a breakpoint, after step

[v8-users] Re: v8 protocol not progressing after id:8

2017-05-18 Thread Anoop R. S.
Hi Harsha, We also developed a debugging framework for JS using V8 inspector. While doing that, in between we were also getting this error, but resolved it by debugging our code. I can send you the websocket messages that we are getting. Maybe that would help in some way. I haven't run your