Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-03 Thread Jakob Kummerow
Minor correction: `gm.py` is a powerful tool, but GN args must be set using `gn args out/` (for your , of course). On Tue, May 3, 2022 at 6:21 AM Ben Noordhuis wrote: > On Sun, May 1, 2022 at 3:46 PM Kazuya Hiruma wrote: > > > > I'm guessing what is wrong is /WX flag. I'm not sure how to turn

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-02 Thread Ben Noordhuis
On Sun, May 1, 2022 at 3:46 PM Kazuya Hiruma wrote: > > I'm guessing what is wrong is /WX flag. I'm not sure how to turn it off. Try passing `treat_warnings_as_errors=false fatal_linker_warnings=false` to tools/dev/gm.py -- -- v8-users mailing list v8-users@googlegroups.com

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Kazuya Hiruma
I've tried fixing compile error. I modified some codes from the nodejs commit. It looks good from previous one but I'm still getting other errors. [1946/2301] CC obj/third_party/zlib/zlib/cpu_features.obj FAILED: obj/third_party/zlib/zlib/cpu_features.obj ninja -t msvc -e environment.x64 --

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Kazuya Hiruma
Thank you for rapid reply! I'll check it out! 2022年5月1日日曜日 16:37:59 UTC+9 Ben Noordhuis: > On Sun, May 1, 2022 at 3:12 AM Kazuya Hiruma wrote: > > > > Hi, there. > > > > I'm struggling with building V8 as a DLL on Windows with MSVC. > > > > I got a lot of compiler errors. (I will show it below)

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Ben Noordhuis
On Sun, May 1, 2022 at 3:12 AM Kazuya Hiruma wrote: > > Hi, there. > > I'm struggling with building V8 as a DLL on Windows with MSVC. > > I got a lot of compiler errors. (I will show it below) > > I also found out a same discussion thread but it wasn't a way to fix the > problem. > >