Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Kazuya Hiruma
Thank you for rapid reply! I'll check it out! 2022年5月1日日曜日 16:37:59 UTC+9 Ben Noordhuis: > On Sun, May 1, 2022 at 3:12 AM Kazuya Hiruma wrote: > > > > Hi, there. > > > > I'm struggling with building V8 as a DLL on Windows with MSVC. > > > > I got a lot of compiler errors. (I will show it below)

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Ben Noordhuis
On Sun, May 1, 2022 at 3:12 AM Kazuya Hiruma wrote: > > Hi, there. > > I'm struggling with building V8 as a DLL on Windows with MSVC. > > I got a lot of compiler errors. (I will show it below) > > I also found out a same discussion thread but it wasn't a way to fix the > problem. > >

Re: [v8-users] Comment Removal

2022-05-01 Thread Jakob Kummerow
I'm not sure why this would reduce memory consumption in V8 -- naturally, V8's parser already disregards comments and whitespace, like any JS engine would. So I would say the right place for such functionality is a minifier/"uglifier" script that developers can run over their code before shipping

Re: [v8-users] [10.0.139.9] Compile error "C2280" with MSVC

2022-05-01 Thread Kazuya Hiruma
I've tried fixing compile error. I modified some codes from the nodejs commit. It looks good from previous one but I'm still getting other errors. [1946/2301] CC obj/third_party/zlib/zlib/cpu_features.obj FAILED: obj/third_party/zlib/zlib/cpu_features.obj ninja -t msvc -e environment.x64 --