[v8-users] Re: [v8-dev] Re: [blink-dev] Intent to Ship: Promise.{all, race, allSettled} optimization

2019-05-06 Thread Benedikt Meurer 
LGTM3

On Mon, May 6, 2019 at 11:12 AM Philip Jägenstedt 
wrote:

> LGTM2
>
> On Thu, May 2, 2019 at 9:22 PM Chris Harrelson 
> wrote:
>
>> LGTM1
>>
>> On Thu, Apr 25, 2019 at 11:43 AM 'Sathya Gunasekaran' via blink-dev <
>> blink-...@chromium.org> wrote:
>>
>>> Contact emails
>>>
>>> gsat...@chromium.org
>>>
>>> Explainer
>>>
>>> https://github.com/tc39/proposal-promise-allSettled/pull/40
>>>
>>> https://github.com/tc39/ecma262/issues/1505
>>>
>>> Spec
>>>
>>> https://github.com/tc39/ecma262/pull/1506/files
>>>
>>> https://github.com/tc39/proposal-promise-allSettled/pull/40/files
>>>
>>> Summary
>>>
>>> Promise.{all <https://tc39.github.io/ecma262/#sec-performpromiseall>,
>>> race <https://tc39.github.io/ecma262/#sec-performpromiserace>,
>>> allSettled <https://tc39.github.io/proposal-promise-allSettled/>}
>>> lookup the constructor of the receiver on every iteration of the loop.
>>> Instead, this change makes the lookup happen only once outside the loop.
>>>
>>> Motivation
>>>
>>> To optimize away the Get and Call of the resolve method on the
>>> constructor, I'd have to check the constructor to see if its resolve method
>>> has been modified or not. If it's not been modified, I can directly call
>>> (or even inline) the builtin %PromiseResolve%, saving the lookup and
>>> call overhead for faster performance.
>>>
>>> Without this patch, I would have to check against the constructor for
>>> every iteration of the loop before going to the fast path. With this patch,
>>> I can do a check against the constructor just once at the beginning.
>>>
>>> The change in behavior with this patch is that if you modify the
>>> constructor's resolve property in the middle of iterating the iterable
>>> argument, then it is not observed.
>>>
>>> Risks
>>>
>>> Interoperability and Compatibility
>>>
>>> There is a very small risk of interop and web compatibility in the case
>>> of Promise.all and Promise.race, as we are modifying the behavior of
>>> methods that have been shipping for a while. There is no risk of interop or
>>> web compat with Promise.allSettled as it is a new proposal.
>>>
>>> I expect the risk to be very low considering the surprising
>>> side-effecting nature of changing the resolve method *while* iterating over
>>> the argument or if there is a user installed ‘resolve’ getter that side
>>> effects.
>>>
>>> Unfortunately it’s not possible to use counters to determine if this
>>> will break or not -- we can’t count the side effects of calling a method.
>>> We can only determine if the resolve method has been patched or not, but
>>> that’s not fully sufficient to determine the risk.
>>>
>>> Given the very low risk of this surprising behavior, I’d like to ship
>>> this to determine if there is any breakage.
>>>
>>> Ergonomics
>>>
>>> N/A
>>>
>>> Activation
>>>
>>> N/A
>>>
>>>
>>> Is this feature supported on all six Blink platforms (Windows, Mac,
>>> Linux, Chrome OS, Android, and Android WebView)?
>>>
>>> Yes.
>>>
>>> Debuggability
>>>
>>> This doesn’t change any of the debugging functionality of Promises.
>>>
>>> Is this feature fully tested by web-platform-tests
>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?
>>> Link to test suite results from wpt.fyi.
>>>
>>> V8 passes all the test262 tests:
>>> https://github.com/tc39/test262/pull/2131
>>>
>>> Entry on the feature dashboard <http://www.chromestatus.com/>
>>>
>>> https://www.chromestatus.com/feature/5171235300311040
>>>
>>> Requesting approval to ship?
>>>
>>> Yes
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMd%2BM7yLMvv55qcOXyW8o_g3sHe0mrYgT_WC%2BmE2GRrqKG-SuA%40mail.gmail.com
>>> <https://groups.goo

Re: [v8-users] Should v8::Promise::Resolver construction depend on v8::Context?

2019-02-05 Thread Benedikt Meurer 
The Array::New() methods probably take the "current context" from the
isolate. But TBH I don't know enough about the API and the way it's
supposed to handle these things, so I have to defer this to adamk@ or
yangguo@ to answer.

-- Benedikt

On Tue, Feb 5, 2019 at 9:47 AM 'Yutaka Hirano' via v8-users <
v8-users@googlegroups.com> wrote:

> > The Array.prototype is also context dependent, i.e. there's one per
> iframe.
>
> Then why Array constructors don't take Context? Currently they are
>
>   static Local New(Isolate* isolate, int length = 0);
>   static Local New(Isolate* isolate, Local* elements,
>   size_t length);
>
> , but do you mean they should take v8::Local?
>
> By the way, my original motivation was, whether v8::Promise::Resolver::New
> could fail (currently it returns MaybeLocal, not Local). I'd like to know
> the reason of the signature difference from other types such as Object,
> Array and so on.
>
>
> On Tue, Feb 5, 2019 at 5:37 PM Benedikt Meurer 
> wrote:
>
>> Yes it's the map on the JSPromise object.
>>
>> The Array.prototype is also context dependent, i.e. there's one per
>> iframe.
>>
>> -- Benedikt
>>
>> On Tue, Feb 5, 2019, 09:33 'Yutaka Hirano' via v8-users <
>> v8-users@googlegroups.com> wrote:
>>
>>> Thank you for the reply!
>>>
>>> > The context is necessary to find the correct promise map
>>> Is the concept corresponding to JSFunction::map()?
>>>
>>> > (which is context dependent b/c the Promise.prototype is).
>>> Does the difference from other types come here? Array.prototype is
>>> context independent and Promise.prototype is context dependent, right?
>>>
>>> > This is hidden somewhere inside Factory.
>>>
>>>
>>> On Tue, Feb 5, 2019 at 5:13 PM Benedikt Meurer 
>>> wrote:
>>>
>>>> Hey Yutaka,
>>>>
>>>> The context is necessary to find the correct promise map (which is
>>>> context dependent b/c the Promise.prototype is). This is hidden somewhere
>>>> inside Factory.
>>>>
>>>> HTH,
>>>> Benedikt
>>>>
>>>> On Tue, Feb 5, 2019, 09:09 Yutaka Hirano  wrote:
>>>>
>>>>> Hi,
>>>>>
>>>>> Currently v8::Promise::Resolver::New is declared as follows.
>>>>>
>>>>> static V8_WARN_UNUSED_RESULT MaybeLocal New(
>>>>> Local context);
>>>>>
>>>>> But Looking at the implementation, I don't see direct context use in
>>>>> Factory::NewJSPromise. Do we actually need the context parameter for the
>>>>> constructor, or can we pass an Isolate instead and make it return
>>>>> Local, like constructors for other types such as v8::Object,
>>>>> v8::Array, v8::Map and so on?
>>>>>
>>>>> Thanks,
>>>>>
>>>>> --
>>>>> --
>>>>> v8-users mailing list
>>>>> v8-users@googlegroups.com
>>>>> http://groups.google.com/group/v8-users
>>>>> ---
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "v8-users" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to v8-users+unsubscr...@googlegroups.com.
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>
>>>> --
>>>>
>>>> Benedikt Meurer
>>>>
>>>> Software Engineer
>>>>
>>>> bmeu...@google.com
>>>>
>>>> Google Germany GmbH
>>>>
>>>> Erika-Mann-Straße 33
>>>> <https://maps.google.com/?q=Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen=gmail=g>
>>>>
>>>> 80636 München
>>>> <https://maps.google.com/?q=Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen=gmail=g>
>>>>
>>>> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>>>>
>>>> Registergericht und -nummer: Hamburg, HRB 86891
>>>>
>>>> Sitz der Gesellschaft: Hamburg
>>>>
>>>> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise
>>>> erhalten haben sollten, leiten Sie diese bitte nicht an jemand anderes
>>>> weiter, löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte
>>>> wissen, dass die E-Mail an die falsche Person gesendet wurde.
>>>

Re: [v8-users] Should v8::Promise::Resolver construction depend on v8::Context?

2019-02-05 Thread Benedikt Meurer 
Yes it's the map on the JSPromise object.

The Array.prototype is also context dependent, i.e. there's one per iframe.

-- Benedikt

On Tue, Feb 5, 2019, 09:33 'Yutaka Hirano' via v8-users <
v8-users@googlegroups.com> wrote:

> Thank you for the reply!
>
> > The context is necessary to find the correct promise map
> Is the concept corresponding to JSFunction::map()?
>
> > (which is context dependent b/c the Promise.prototype is).
> Does the difference from other types come here? Array.prototype is context
> independent and Promise.prototype is context dependent, right?
>
> > This is hidden somewhere inside Factory.
>
>
> On Tue, Feb 5, 2019 at 5:13 PM Benedikt Meurer 
> wrote:
>
>> Hey Yutaka,
>>
>> The context is necessary to find the correct promise map (which is
>> context dependent b/c the Promise.prototype is). This is hidden somewhere
>> inside Factory.
>>
>> HTH,
>> Benedikt
>>
>> On Tue, Feb 5, 2019, 09:09 Yutaka Hirano  wrote:
>>
>>> Hi,
>>>
>>> Currently v8::Promise::Resolver::New is declared as follows.
>>>
>>> static V8_WARN_UNUSED_RESULT MaybeLocal New(
>>> Local context);
>>>
>>> But Looking at the implementation, I don't see direct context use in
>>> Factory::NewJSPromise. Do we actually need the context parameter for the
>>> constructor, or can we pass an Isolate instead and make it return
>>> Local, like constructors for other types such as v8::Object,
>>> v8::Array, v8::Map and so on?
>>>
>>> Thanks,
>>>
>>> --
>>> --
>>> v8-users mailing list
>>> v8-users@googlegroups.com
>>> http://groups.google.com/group/v8-users
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "v8-users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to v8-users+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>>
>> Benedikt Meurer
>>
>> Software Engineer
>>
>> bmeu...@google.com
>>
>> Google Germany GmbH
>>
>> Erika-Mann-Straße 33
>> <https://maps.google.com/?q=Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen=gmail=g>
>>
>> 80636 München
>> <https://maps.google.com/?q=Erika-Mann-Stra%C3%9Fe+33+80636+M%C3%BCnchen=gmail=g>
>>
>> Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
>>
>> Registergericht und -nummer: Hamburg, HRB 86891
>>
>> Sitz der Gesellschaft: Hamburg
>>
>> Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
>> haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
>> löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
>> dass die E-Mail an die falsche Person gesendet wurde.
>>
>>
>>
>> This e-mail is confidential. If you received this communication by
>> mistake, please don't forward it to anyone else, please erase all copies
>> and attachments, and please let me know that it has gone to the wrong
>> person.
>>
>> --
>> --
>> v8-users mailing list
>> v8-users@googlegroups.com
>> http://groups.google.com/group/v8-users
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to v8-users+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 

Benedikt Meurer

Software Engineer

bmeu...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.



This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Should v8::Promise::Resolver construction depend on v8::Context?

2019-02-05 Thread Benedikt Meurer 
Hey Yutaka,

The context is necessary to find the correct promise map (which is context
dependent b/c the Promise.prototype is). This is hidden somewhere inside
Factory.

HTH,
Benedikt

On Tue, Feb 5, 2019, 09:09 Yutaka Hirano  wrote:

> Hi,
>
> Currently v8::Promise::Resolver::New is declared as follows.
>
> static V8_WARN_UNUSED_RESULT MaybeLocal New(
> Local context);
>
> But Looking at the implementation, I don't see direct context use in
> Factory::NewJSPromise. Do we actually need the context parameter for the
> constructor, or can we pass an Isolate instead and make it return
> Local, like constructors for other types such as v8::Object,
> v8::Array, v8::Map and so on?
>
> Thanks,
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 

Benedikt Meurer

Software Engineer

bmeu...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.



This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Re: [blink-dev] Intent to Ship: RegExp @@matchAll / String.prototype.matchAll

2018-12-14 Thread Benedikt Meurer 
LGTM!

On Fri, Dec 14, 2018 at 1:17 PM PhistucK  wrote:

> Can you make the example clearer?
> ["...", index: 0, input: "..."] is unfamiliar, invalid syntax.
>
> ☆*PhistucK*
>
>
> On Fri, Dec 14, 2018 at 2:19 AM Peter Wong 
> wrote:
>
>> Contact emails
>> peter.wm.w...@gmail.com
>> jgru...@chromium.org
>> yang...@chromium.org
>>
>> math...@chromium.org
>>
>>
>> Spec
>> https://github.com/tc39/proposal-string-matchall/
>>
>> https://tc39.github.io/proposal-string-matchall/
>>
>>
>> Summary
>> String.prototype.matchAll behaves similarly to String.prototype.match,
>> but returns a full regexp result object for each match in a global or
>> sticky regexp.
>>
>> Motivation
>> This offers a simple way to iterate over matches when access to e.g.
>> capture groups is needed.
>>
>> const string = 'Magic hex numbers: DEADBEEF CAFE 8BADF00D';
>> const regex = /\b[0-9a-fA-F]+\b/g;
>> for (const match of string.matchAll(regex)) {
>>  console.log(match);
>> }
>>
>> // Iteration 1:
>> [
>>  'DEADBEEF',
>>  index: 19,
>>  input: 'Magic hex numbers: DEADBEEF CAFE 8BADF00D'
>> ]
>>
>> // Iteration 2:
>> [
>>  'CAFE',
>>  index: 28,
>>  input: 'Magic hex numbers: DEADBEEF CAFE 8BADF00D'
>> ]
>>
>> // Iteration 3:
>> [
>>  '8BADF00D',
>>  index: 33,
>>  input: 'Magic hex numbers: DEADBEEF CAFE 8BADF00D'
>> ]
>>
>>
>> Interoperability risk
>> Firefox: In development -
>> https://bugzilla.mozilla.org/show_bug.cgi?id=1435829
>> Edge: No public signals
>> Safari: No public signals -
>> https://bugs.webkit.org/show_bug.cgi?id=186694
>> Web developers: Positive
>>
>> Compatibility risk
>> The spec has undergone a few updates and depending on whether other
>> implementations have kept up, there is a possibility V8 could differ in
>> behavior.  At the time of writing, V8 is current with all the latest spec
>> updates and have contributed updates to the test262 test suite to minimize
>> difference between other implementations.
>>
>> V8 tests (mjsunit) as well as all test262 tests pass for this feature.
>>
>> Will this feature be supported on all six Blink platforms (Windows, Mac,
>> Linux,
>> Chrome OS, Android, and Android WebView)?
>>
>> Yes
>>
>> Link to entry on the Chrome Platform Status
>> https://www.chromestatus.com/features/5520028858318848
>>
>> Requesting approval to ship?
>> Yes. Note that since this is a V8/JS feature, this post is just an FYI to
>> blink-dev — no signoff from Blink API owners is required.
>>
>> --
>>
> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to blink-dev+unsubscr...@chromium.org.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAKm-Q%2BuNU%3D%2BbSgu87THKGedRbf1OuCQSsJbmRgK5iPWAVO%2BDA%40mail.gmail.com
>> <https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAAKm-Q%2BuNU%3D%2BbSgu87THKGedRbf1OuCQSsJbmRgK5iPWAVO%2BDA%40mail.gmail.com?utm_medium=email_source=footer>
>> .
>>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 

Benedikt Meurer

Software Engineer

bmeu...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.



This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Fwd: Intent to ship: Optimize await and AsyncFromSyncIterator

2018-09-28 Thread Benedikt Meurer 
LGTM!

On Fri, Sep 28, 2018 at 4:06 PM Adam Klein  wrote:

> LGTM2
>
> On Fri, Sep 28, 2018 at 9:39 AM 'Mathias Bynens' via v8-users <
> v8-users@googlegroups.com> wrote:
>
>> LGTM
>>
>> On Fri, Sep 28, 2018 at 9:26 AM Maya Lekova 
>> wrote:
>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> *Contact emailsmslek...@chromium.org
>>> Explainerhttps://docs.google.com/document/d/1kL08cz4lR6gO5b2FATNK3QAfS8t-6K6kdk88U-n8tug/edit?usp=sharing
>>> <https://docs.google.com/document/d/1kL08cz4lR6gO5b2FATNK3QAfS8t-6K6kdk88U-n8tug/edit?usp=sharing>SpecThe
>>> ECMAScript specification change reached consensus. Pull request:
>>> https://github.com/tc39/ecma262/pull/1250
>>> <https://github.com/tc39/ecma262/pull/1250>The tag review process is not
>>> needed, TC39 consensus was reached instead.SummaryThe goal of this change
>>> is to reduce the native “await” functionality to only take 1 tick on the
>>> microtask queue instead of 3.Is this feature supported on all six Blink
>>> platforms (Windows, Mac, Linux, Chrome OS, Android, and Android
>>> WebView)?Yes.RisksInteroperability and CompatibilityEdge: ShippedFirefox:
>>> No signalsSafari: No signalsWeb developers: Shouldn’t affect web
>>> developers, as most of them transpile away async/await and Babel already
>>> ships with the new behaviour.ActivationThe new behaviour won’t affect the
>>> way async/await is being used.Is this feature fully tested by
>>> web-platform-tests
>>> <https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md>?Test262
>>> tests are being implemented. We have related tests in the V8 repository in
>>> test/inspector/debugger.Entry on the feature dashboard
>>> <http://www.chromestatus.com/>Fits under
>>> https://www.chromestatus.com/feature/5643236399906816
>>> <https://www.chromestatus.com/feature/5643236399906816>, as this is simply
>>> an errata to the spec.*
>>> ---
>>> Best regards,
>>> Maya
>>>
>>>
>>> --
>>> --
>>> v8-users mailing list
>>> v8-users@googlegroups.com
>>> http://groups.google.com/group/v8-users
>>> ---
>>> You received this message because you are subscribed to the Google
>>> Groups "v8-users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to v8-users+unsubscr...@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>> --
>> --
>> v8-users mailing list
>> v8-users@googlegroups.com
>> http://groups.google.com/group/v8-users
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to v8-users+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 

Benedikt Meurer

Software Engineer

bmeu...@google.com

Google Germany GmbH

Erika-Mann-Straße 33

80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891

Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich. Falls sie diese fälschlicherweise erhalten
haben sollten, leiten Sie diese bitte nicht an jemand anderes weiter,
löschen Sie alle Kopien und Anhänge davon und lassen Sie mich bitte wissen,
dass die E-Mail an die falsche Person gesendet wurde.



This e-mail is confidential. If you received this communication by mistake,
please don't forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Re: [blink-dev] Intent to ship: JSON ⊂ ECMAScript

2018-02-16 Thread Benedikt Meurer 
LGTM!

On Fri, Feb 16, 2018 at 7:57 PM Sathya Gunasekaran <gsat...@chromium.org>
wrote:

> LGTM
>
> On Fri, Feb 16, 2018 at 5:24 AM, PhistucK <phist...@gmail.com> wrote:
> > I know.
> >
> > Regarding "public support" - not "opposed" does not necessarily mean
> > "support" (it could be neutral). Transparency is important in
> > chromestatus.com (and in intent, I would argue).
> > Second, web developers are not part of the TC39 stages, so support or
> > reactions from them are not a given (not as far as "strongly positive").
> > I think it makes sense to add links for opinions that are not your own.
> >
> > Just my two or three cents.
> >
> >
> > ☆PhistucK
> >
> > On Fri, Feb 16, 2018 at 3:07 PM, Mathias Bynens <m...@google.com> wrote:
> >>
> >> Note that since this is a V8/JS feature, this post is just an FYI to
> >> blink-dev — no signoff from Blink API owners is required.
> >>
> >> For ECMAScript features like this one, if a browser vendor would be
> >> opposed to this proposal, they would block its advancement at TC39.
> Given
> >> that this proposal already made it to Stage 3 I would be surprised if
> >> vendors would suddenly change their mind now.
> >>
> >> On Fri, Feb 16, 2018 at 1:50 PM, PhistucK <phist...@gmail.com> wrote:
> >>>
> >>> (At least on blink-dev)
> >>> "Interoperability risk" should have links for citing each vendor and
> web
> >>> developer support.
> >>>
> >>>
> >>> ☆PhistucK
> >>>
> >>> On Fri, Feb 16, 2018 at 2:15 PM, Mathias Bynens <math...@chromium.org>
> >>> wrote:
> >>>>
> >>>> Contact emails
> >>>>
> >>>> math...@chromium.org
> >>>>
> >>>>
> >>>> Spec
> >>>>
> >>>> https://github.com/tc39/proposal-json-superset
> >>>>
> >>>>
> >>>> Summary
> >>>>
> >>>> A Stage 3 proposal makes ECMAScript a syntactic superset of JSON by
> >>>> allowing U+2028 and U+2029 in string literals.
> >>>>
> >>>>
> >>>> Motivation
> >>>>
> >>>> ECMAScript claims JSON as a subset in JSON.parse, but (as has been
> >>>> well-documented) that is not true because JSON strings can contain
> unescaped
> >>>> U+2028 LINE SEPARATOR and U+2029 PARAGRAPH SEPARATOR characters while
> >>>> ECMAScript strings cannot.
> >>>>
> >>>> These exceptions add unnecessary complexity to the specification and
> >>>> increase the cognitive burden on both implementers and users,
> allowing for
> >>>> the introduction of subtle bugs. Also, as a lesser but concrete
> corollary
> >>>> problem, certain source concatenation and construction tasks currently
> >>>> require additional steps to process valid JSON into valid ECMAScript
> before
> >>>> embedding it.
> >>>>
> >>>>
> >>>> Interoperability risk
> >>>>
> >>>> Firefox: Public support
> >>>>
> >>>> Edge: Public support
> >>>>
> >>>> Safari: Public support
> >>>>
> >>>> Web developers: Strongly positive
> >>>>
> >>>>
> >>>> Compatibility risk
> >>>>
> >>>> This change is backwards-compatible. User-visible effects will be
> >>>> limited to the elimination of SyntaxError completions when parsing
> strings
> >>>> that include unescaped LINE SEPARATOR or PARAGRAPH SEPARATOR
> characters,
> >>>> which in practice are uncommon.
> >>>>
> >>>>
> >>>> Is this feature fully tested?
> >>>>
> >>>> Yes; see
> >>>>
> v8/test/cctest/test-parsing/LineOrParagraphSeparator{AsLineTerminator,InStringLiteral,InStringLiteralHarmony}.
> >>>>
> >>>>
> >>>> Tracking bug
> >>>>
> >>>> https://bugs.chromium.org/p/v8/issues/detail?id=7418
> >>>>
> >>>>
> >>>> Link to entry on the Chrome Platform Status dashboard
> >>>>
> >>>> https://www.chromestatus.com/features/6102319234023424
> >>>>
> >>>>
> &

Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Benedikt Meurer 
LGTM

Mathias Bynens <math...@chromium.org> schrieb am Fr., 9. Feb. 2018, 16:36:

> Contact emails math...@chromium.org Spec
> https://github.com/tc39/proposal-string-left-right-trim Summary Until
> now, String.prototype.{trimLeft,trimRight} were non-standard language
> extensions, required for Web compatibility. The Stage 3 proposal at
> https://github.com/tc39/proposal-string-left-right-trim standardizes this
> functionality as String.prototype.{trimStart,trimEnd}, and defines
> String.prototype.{trimLeft,trimRight} as aliases for backwards
> compatibility. Vendor signals Firefox: Public support Edge: Public
> support Safari: In development Web developers: Positive Compatibility risk
> There could be a compatibility risk, but that seems unlikely. We won’t
> know for sure until we try shipping it. Ongoing technical constraints
> None Will this feature be supported on all six Blink platforms (Windows,
> Mac, Linux, Chrome OS, Android, and Android WebView)?
> Yes
> Tracking bug
> https://bugs.chromium.org/p/v8/issues/detail?id=6530 Link to entry on the
> Chrome Platform Status
> https://www.chromestatus.com/features/479006651936 Requesting
> approval to ship? Yes
>
> Note that since this is a V8/JS feature, this post is just an FYI to
> blink-dev — no signoff from Blink API owners is required.
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
-- 



* •  *
*Benedikt Meurer** •  **Google Germany GmbH*
* •  *Erika-Mann-Str. 33
<https://maps.google.com/?q=Erika-Mann-Str.+33*+**%C2%A0%E2%80%A2+%C2%A0*80636+Munich=gmail=g>
* •  *80636 Munich
<https://maps.google.com/?q=Erika-Mann-Str.+33*+**%C2%A0%E2%80%A2+%C2%A0*80636+Munich=gmail=g>

 •  bmeu...@google.com


Geschäftsführer: Paul Manicle, Halimah DeLaine Prado

Registergericht und -nummer: Hamburg, HRB 86891 Sitz der Gesellschaft:
Hamburg

Diese E-Mail ist vertraulich. Wenn Sie nicht der richtige Adressat sind,
leiten Sie diese bitte nicht weiter, informieren Sie den Absender und
löschen Sie die E-Mail und alle Anhänge. Vielen Dank. This e-mail is
confidential. If you are not the right addressee please do not forward it,
please inform the sender, and please erase this e-mail including any
attachments. Thanks.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] 32-bit powerpc -- a lost cause?

2017-07-26 Thread Benedikt Meurer 
Hey Håvard,

The ppc port is not maintained by the V8 team itself, but by IBM (see
src/ppc/OWNERS). I don't know about the state and scope of the port. Maybe
you want to reach out to the port owners.

-- Benedikt

On Mon, Jul 24, 2017 at 7:39 PM Håvard Eidnes 
wrote:

> Hi,
>
> I stumbled in on v8 via node.js -- v8 now appears to have some powerpc
> support, and I managed to get node.js to link on my NetBSD/macppc 8.0_BETA
> system after some persuasion.  However, it dumps core with illegal
> instruction
> on the first attempt at running "node", and by the looks of it that's
> because there's
> used some powerpc64-only instructions (fctidz  f13,f13).
>
> Is this the result of a deliberate decision not to support 32-bit powerpc?
> Or, in other words, even if the "ppc64-only instructions" issue could be
> solved,
> would there be other and more serious issues lurking further ahead making
> progress
> difficult or impossible?
>
> Any hints would be much appreciated.
>
> Best regards,
>
> - Håvard
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Re: [blink-dev] Intent to ship: Trailing comma in JavaScript function parameter lists

2017-01-14 Thread Benedikt Meurer 
LGTM

PhistucK  schrieb am Sa., 14. Jan. 2017, 00:55:

>
> On Fri, Jan 13, 2017 at 11:55 PM, jwolfe  wrote:
>
> Edge is shipping with this feature enabled (
> https://kangax.github.io/compat-table/es2016plus/ ).
>
>
> ​Actually, it is only shipping in preview builds of Windows 10 Creator's
> Update. EdgeHTML 15 is not the current stable build​. So the situation is
> the same as with WebKit and Gecko.
>
> I really do not like this feature (why does C++ exclude this?)...
> JavaScript is loose enough as it is, but this is not the place for such
> feedback. :)
>
>
>
> ☆*PhistucK*
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] V8 build failure for PowerPC

2016-10-28 Thread Benedikt Meurer 
You need to run gclient sync after switching branches.

HTH,
Benedikt


Benedikt Meurer |  Software Engineer, V8 |  Google Germany GmbH |
Erika-Mann-Str.
33, 80636 München

Registergericht und -nummer: Hamburg, HRB 86891 | Sitz der Gesellschaft:
Hamburg | Geschäftsführer: Matthew Scott Sucherman, Paul Terence Manicle

On Fri, Oct 28, 2016 at 11:59 AM, Yugandha Deshpande <
yugandha.deshpa...@gmail.com> wrote:

> Hello,
>
> *Platform:* IBM Power PC.
>
> *OS:* Ubuntu 16.04
>
>
>
> I am trying to buils V8 stable branch from source.
>
>
>
> *Steps I used:*
>
>
> fetch v8
> cd v8
> git checkout branch-heads/5.4
> make ppc64.release
>
>
>
>
> *But build is failing for make with following error:*
>
>
>
> In file included from .././src/isolate.h:26:0,
>
>  from .././src/isolate-inl.h:8,
>
>  from .././test/cctest/cctest.h:32,
>
>  from ../test/cctest/test-trace-event.cc:11:
>
> ../test/cctest/test-trace-event.cc: In function 'void
> TestTestEventInContext()':
>
> .././src/tracing/trace-event.h:284:52: error: request for member 'raw_id'
> in 'isolate_id', which is of non-class type 'uint64_t {aka long unsigned
> int}'
>
>INTERNAL_TRACE_EVENT_UID(scoped_context)(context.raw_id());
>
> ^
>
> .././base/trace_event/common/trace_event_common.h:953:3: note: in
> expansion of macro 'INTERNAL_TRACE_EVENT_SCOPED_CONTEXT'
>
>INTERNAL_TRACE_EVENT_SCOPED_CONTEXT(category_group, name, context)
>
>^
>
> ../test/cctest/test-trace-event.cc:267:5: note: in expansion of macro
> 'TRACE_EVENT_SCOPED_CONTEXT'
>
>  TRACE_EVENT_SCOPED_CONTEXT("v8-cat", "Isolate", isolate_id);
>
>  ^
>
> test/cctest/cctest.target.ppc64.release.mk:325: recipe for target
> '/v8/out/ppc64.release/obj.target/cctest/test/cctest/test-trace-event.o'
> failed
>
> make[1]: *** 
> [/v8/out/ppc64.release/obj.target/cctest/test/cctest/test-trace-event.o]
> Error 1
>
> make[1]: Leaving directory '/v8/out'
>
> Makefile:307: recipe for target 'ppc64.release' failed
>
> make: *** [ppc64.release] Error 2
>
>
>
> Please let me know where I am missing out.
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] Is there intent to allow optimization of generator functions?

2015-12-17 Thread Benedikt Meurer 
Hey Ben,

Mainly that the generator state is saved/restored by just copying the full
function frame in fullcodegen, which is of course not portable to the
optimizing compilers. :-)
A better approach would basically context allocate everything and just
reenter the context, but that will be slow by default in the
interpreter/fullcodegen; so we need to find a compromise in between.

HTH,
Benedikt

On Thu, Dec 17, 2015 at 11:13 AM, Ben Noordhuis <i...@bnoordhuis.nl> wrote:

> On Thu, Dec 17, 2015 at 4:18 AM, Benedikt Meurer <bmeu...@chromium.org>
> wrote:
> > Hello Donato,
> >
> > Currently generators cannot be optimized due to certain implementation
> > choices. But we plan to revisit those decisions next year, which should
> > allow us to optimize generator functions as well.
> >
> > HTH,
> > Benedikt
>
> Benedikt, for my edification: what implementation choices are those?
>
> (For background, I'm working on a toy JS run-time and I hope to get
> around to implementing generators in the next few weeks.)
>
> --
> --
> v8-users mailing list
> v8-users@googlegroups.com
> http://groups.google.com/group/v8-users
> ---
> You received this message because you are subscribed to the Google Groups
> "v8-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to v8-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [v8-users] PSA: v8 requires C++11 now

2014-10-20 Thread Benedikt Meurer 

On Oct 7, 2014, at 09:48 , Sven Panne svenpa...@chromium.org wrote:

 Following Chrome's lead, v8 will require a C++11-capable compiler now. Note 
 that we don't require a *full* C++11 implementation, basically we rely on 
 language features, not library/header ones. For details see 
 http://chromium-cpp.appspot.com/.
 
 Some features already sneaked in earlier and there were no complaints, so we 
 don't expect any problems for embedders. Toolchains don't have to be 
 brand-new, e.g. GCC 4.6/clang 3.0(?) or later are enough, for Windows we 
 require MSVS2013.

Note that we actually require GCC 4.8 just like Chromium does, so be prepared 
that support for GCC 4.6 will go away soonish.

-- Benedikt

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
v8-users group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-users] GTest and GMock dependencies

2014-08-05 Thread Benedikt Meurer 
Hello everyone,

In the process of trying to reuse more of the existing Google/Chrome 
infrastructure, we've now added dependencies to GTest and GMock for unit tests. 
Please make sure to rerun make dependencies (on Linux/Mac) or checkout 
testing/gtest and testing/gmock manually as documented on the wiki (on Windows).

best,
Benedikt

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
v8-users group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[v8-users] Support for Mac OS X 10.5 is going away

2013-09-11 Thread Benedikt Meurer 
Hello everybody,

This is to inform you that upcoming releases of V8 will required at least Mac 
OS X 10.6 (Snow Leopard).

greets,
Benedikt

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
v8-users group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.