Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-04-01 Thread Adam Klein 
LGTM3

On Fri, Mar 29, 2019 at 5:37 PM Sam Goto  wrote:

> LGTM++!! Exciting!
>
> On Thu, Mar 28, 2019, 12:21 PM 'Mathias Bynens' via blink-dev <
> blink-...@chromium.org> wrote:
>
>> LGTM now that the conflict has been resolved!
>>
>> On Thu, Mar 28, 2019 at 12:01 PM 'Sathya Gunasekaran' via blink-dev <
>> blink-...@chromium.org> wrote:
>>
>>> On Thu, Mar 15, 2018 at 2:25 PM Adam Klein  wrote:
>>> >
>>> > There's a possible conflict between this feature and another proposal,
>>> Extended Numeric Literals. The issue,
>>> https://github.com/tc39/proposal-extended-numeric-literals/issues/7,
>>> should be addressed at next week's TC39 meeting, and I'd like to see it
>>> settled before shipping this in V8.
>>> >
>>>
>>> This issue has been resolved.
>>>
>>> > On Thu, Mar 15, 2018 at 5:02 PM, Sathya Gunasekaran <
>>> gsat...@chromium.org> wrote:
>>> >>
>>> >> Note that this is a v8/JavaScript feature, so this post is just an
>>> FYI for blink-dev — no sign-off from Blink API owners is required.
>>> >>
>>> >>
>>> >> Contact Emails:
>>> >> gsat...@chromium.org
>>> >> b...@b6n.ch
>>> >>
>>> >> Spec:
>>> >> https://tc39.github.io/proposal-numeric-separator/
>>> >>
>>> >> Summary:
>>> >> This feature enables developers to make their numeric literals more
>>> readable by creating a visual separation between groups of digits. Using
>>> underscores (_, U+005F) as separators helps improve readability for numeric
>>> literals, for ex: 1_000_000_000.
>>> >>
>>> >> Interoperability and Compatibility Risk:
>>> >> This is a Stage3 feature in the TC39 process. Previously this was a
>>> SyntaxError so there is no compat risk.
>>> >>
>>> >> Safari and Edge have not implemented this feature. This is under
>>> development in Firefox.
>>> >>
>>> >> V8 tests as well as test262 tests pass.
>>> >>
>>> >> Tracking bug:
>>> >> https://bugs.chromium.org/p/v8/issues/detail?id=7317
>>> >>
>>> >> Chromestatus entry:
>>> >> https://www.chromestatus.com/feature/5829906369871872
>>> >>
>>> >> --
>>> >> --
>>> >> v8-users mailing list
>>> >> v8-users@googlegroups.com
>>> >> http://groups.google.com/group/v8-users
>>> >> ---
>>> >> You received this message because you are subscribed to the Google
>>> Groups "v8-users" group.
>>> >> To unsubscribe from this group and stop receiving emails from it,
>>> send an email to v8-users+unsubscr...@googlegroups.com.
>>> >> For more options, visit https://groups.google.com/d/optout.
>>> >
>>> >
>>> > --
>>> > You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> > To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEvLGcLP3jm-TDH9FkrwvtrYiz4%2BEGYvHAQRg5UP98PQHKuRXw%40mail.gmail.com
>>> .
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "blink-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to blink-dev+unsubscr...@chromium.org.
>>> To view this discussion on the web visit
>>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMd%2BM7yE0uhhY5SssaaKxF%2Bw-hY7ibSVd2fsbEPD3A6C%2BpLa1w%40mail.gmail.com
>>> .
>>>
>>> --
>> You received this message because you are subscribed to the Google Groups
>> "blink-dev" group.
>> To view this discussion on the web visit
>> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CADizRgZ2zF%2B2oC_Rf5CQNbT6ueBFXeDpeWYC0SaawK0eM0h0fA%40mail.gmail.com
>> 
>> .
>>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-03-28 Thread 'Mathias Bynens' via v8-users 
LGTM now that the conflict has been resolved!

On Thu, Mar 28, 2019 at 12:01 PM 'Sathya Gunasekaran' via blink-dev <
blink-...@chromium.org> wrote:

> On Thu, Mar 15, 2018 at 2:25 PM Adam Klein  wrote:
> >
> > There's a possible conflict between this feature and another proposal,
> Extended Numeric Literals. The issue,
> https://github.com/tc39/proposal-extended-numeric-literals/issues/7,
> should be addressed at next week's TC39 meeting, and I'd like to see it
> settled before shipping this in V8.
> >
>
> This issue has been resolved.
>
> > On Thu, Mar 15, 2018 at 5:02 PM, Sathya Gunasekaran <
> gsat...@chromium.org> wrote:
> >>
> >> Note that this is a v8/JavaScript feature, so this post is just an FYI
> for blink-dev — no sign-off from Blink API owners is required.
> >>
> >>
> >> Contact Emails:
> >> gsat...@chromium.org
> >> b...@b6n.ch
> >>
> >> Spec:
> >> https://tc39.github.io/proposal-numeric-separator/
> >>
> >> Summary:
> >> This feature enables developers to make their numeric literals more
> readable by creating a visual separation between groups of digits. Using
> underscores (_, U+005F) as separators helps improve readability for numeric
> literals, for ex: 1_000_000_000.
> >>
> >> Interoperability and Compatibility Risk:
> >> This is a Stage3 feature in the TC39 process. Previously this was a
> SyntaxError so there is no compat risk.
> >>
> >> Safari and Edge have not implemented this feature. This is under
> development in Firefox.
> >>
> >> V8 tests as well as test262 tests pass.
> >>
> >> Tracking bug:
> >> https://bugs.chromium.org/p/v8/issues/detail?id=7317
> >>
> >> Chromestatus entry:
> >> https://www.chromestatus.com/feature/5829906369871872
> >>
> >> --
> >> --
> >> v8-users mailing list
> >> v8-users@googlegroups.com
> >> http://groups.google.com/group/v8-users
> >> ---
> >> You received this message because you are subscribed to the Google
> Groups "v8-users" group.
> >> To unsubscribe from this group and stop receiving emails from it, send
> an email to v8-users+unsubscr...@googlegroups.com.
> >> For more options, visit https://groups.google.com/d/optout.
> >
> >
> > --
> > You received this message because you are subscribed to the Google
> Groups "blink-dev" group.
> > To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEvLGcLP3jm-TDH9FkrwvtrYiz4%2BEGYvHAQRg5UP98PQHKuRXw%40mail.gmail.com
> .
>
> --
> You received this message because you are subscribed to the Google Groups
> "blink-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to blink-dev+unsubscr...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAMd%2BM7yE0uhhY5SssaaKxF%2Bw-hY7ibSVd2fsbEPD3A6C%2BpLa1w%40mail.gmail.com
> .
>
>

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: [blink-dev] Re: [v8-users] Intent to Ship: Numeric separators

2019-03-28 Thread Sathya Gunasekaran 
(retrying from @chromium.org account)

On Thu, Mar 15, 2018 at 2:25 PM Adam Klein  wrote:
>
> There's a possible conflict between this feature and another proposal, 
> Extended Numeric Literals. The issue, 
> https://github.com/tc39/proposal-extended-numeric-literals/issues/7, should 
> be addressed at next week's TC39 meeting, and I'd like to see it settled 
> before shipping this in V8.

This issue has been resolved.

> On Thu, Mar 15, 2018 at 5:02 PM, Sathya Gunasekaran  
> wrote:
>>
>> Note that this is a v8/JavaScript feature, so this post is just an FYI for 
>> blink-dev — no sign-off from Blink API owners is required.
>>
>>
>> Contact Emails:
>> gsat...@chromium.org
>> b...@b6n.ch
>>
>> Spec:
>> https://tc39.github.io/proposal-numeric-separator/
>>
>> Summary:
>> This feature enables developers to make their numeric literals more readable 
>> by creating a visual separation between groups of digits. Using underscores 
>> (_, U+005F) as separators helps improve readability for numeric literals, 
>> for ex: 1_000_000_000.
>>
>> Interoperability and Compatibility Risk:
>> This is a Stage3 feature in the TC39 process. Previously this was a 
>> SyntaxError so there is no compat risk.
>>
>> Safari and Edge have not implemented this feature. This is under development 
>> in Firefox.
>>
>> V8 tests as well as test262 tests pass.
>>
>> Tracking bug:
>> https://bugs.chromium.org/p/v8/issues/detail?id=7317
>>
>> Chromestatus entry:
>> https://www.chromestatus.com/feature/5829906369871872
>>
>> --
>> --
>> v8-users mailing list
>> v8-users@googlegroups.com
>> http://groups.google.com/group/v8-users
>> ---
>> You received this message because you are subscribed to the Google Groups 
>> "v8-users" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to v8-users+unsubscr...@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>
>
> --
> You received this message because you are subscribed to the Google Groups 
> "blink-dev" group.
> To view this discussion on the web visit 
> https://groups.google.com/a/chromium.org/d/msgid/blink-dev/CAEvLGcLP3jm-TDH9FkrwvtrYiz4%2BEGYvHAQRg5UP98PQHKuRXw%40mail.gmail.com.

-- 
-- 
v8-users mailing list
v8-users@googlegroups.com
http://groups.google.com/group/v8-users
--- 
You received this message because you are subscribed to the Google Groups 
"v8-users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to v8-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.