[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Drew Wilson
Resending to v8-users since apparently I didn't have permission to post previously. On Thu, Nov 27, 2014 at 10:13 AM, Drew Wilson atwil...@chromium.org wrote: What impact do we expect on web compatibility from apps that may already be adding attributes named include, etc to their String

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
On Thu, Nov 27, 2014 at 10:13 AM, Drew Wilson atwil...@chromium.org wrote: What impact do we expect on web compatibility from apps that may already be adding attributes named include, etc to their String objects? I think that adding attributes that Firefox is already shipping should be

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Drew Wilson
On Thu, Nov 27, 2014 at 10:35 AM, Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:13 AM, Drew Wilson atwil...@chromium.org wrote: What impact do we expect on web compatibility from apps that may already be adding attributes named include, etc to their String objects?

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
Can we add a console log (not a warning) for the canary/dev/beta run (perhaps stable, too?) for a little while to aid developers with possible breakages? If String.prototype.includes is overridden, deleted or accessed (called or gotten), the log would be printed. ☆*PhistucK* On Thu, Nov 27,

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
On Thu, Nov 27, 2014 at 11:01 AM, Drew Wilson atwil...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:35 AM, Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:13 AM, Drew Wilson atwil...@chromium.org wrote: What impact do we expect on web compatibility from apps that

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Jochen Eisinger
On Thu Nov 27 2014 at 11:39:17 AM Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 11:01 AM, Drew Wilson atwil...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:35 AM, Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:13 AM, Drew Wilson

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
On Thu, Nov 27, 2014 at 11:44 AM, Jochen Eisinger joc...@chromium.org wrote: On Thu Nov 27 2014 at 11:39:17 AM Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 11:01 AM, Drew Wilson atwil...@chromium.org wrote: On Thu, Nov 27, 2014 at 10:35 AM, Dmitry Lomov

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
One suggestion that came out of discussions with folks is: - add an on-by-default flag 'Enable new Javascript features' that could be turned off at run-time. Javascript features we ship will be under that flag for 1 stable release. I'll investigate feasibility of that. On Thu, Nov 27, 2014 at

Re: [v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread 'Andreas Rossberg' via v8-users
On 27 November 2014 at 12:09, Dmitry Lomov dslo...@chromium.org wrote: One suggestion that came out of discussions with folks is: - add an on-by-default flag 'Enable new Javascript features' that could be turned off at run-time. Javascript features we ship will be under that flag for 1 stable

Re: [v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
This is to ease debugging, not to solve every single case. As much as possible, log it. On a 'best available' case. ☆*PhistucK* On Thu, Nov 27, 2014 at 1:14 PM, 'Andreas Rossberg' via blink-dev blink-...@chromium.org wrote: On 27 November 2014 at 11:39, Dmitry Lomov dslo...@chromium.org

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Mathias Bynens
On Thu, Nov 27, 2014 at 12:52 PM, Philip Jägenstedt phil...@opera.com wrote: It sure sounds like 'contains' would be less likely to cause trouble, and is also a slightly better name IMHO. Is Mozilla on board with renaming it? If they're not keen, I think following their lead with 'contains'

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
This is very debateable, really. To me, it makes sense (and in my experience, also exists) that contains makes more sense (as a shortcuts for return this.indexOf(str) !== -1) than 'includes'. ☆*PhistucK* On Thu, Nov 27, 2014 at 1:52 PM, Philip Jägenstedt phil...@opera.com wrote: On Thu, Nov

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
On Thu, Nov 27, 2014 at 12:54 PM, Mathias Bynens mathi...@opera.com wrote: On Thu, Nov 27, 2014 at 12:52 PM, Philip Jägenstedt phil...@opera.com wrote: It sure sounds like 'contains' would be less likely to cause trouble, and is also a slightly better name IMHO. Is Mozilla on board with

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
*shortcut My last message was probably confusing, so continuing it - By that, I mean that it makes more sense for 'contains' to exists already on the web, than for 'includes'. ☆*PhistucK* On Thu, Nov 27, 2014 at 1:55 PM, PhistucK phist...@gmail.com wrote: This is very debateable, really. To

[v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
*exist 'contains' is the obvious choice, 'includes' is not. This is what I mean. While 'contains' is better named, 'includes' is less risky and therefore should be chosen. I am finally done, I think. Sorry for the triple post. ☆*PhistucK* On Thu, Nov 27, 2014 at 1:57 PM, PhistucK

Re: [v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread Dmitry Lomov
On Thu, Nov 27, 2014 at 12:37 PM, PhistucK phist...@gmail.com wrote: This is to ease debugging, not to solve every single case. As much as possible, log it. On a 'best available' case. Logging would be prohibitively expensive as well, and lead to too many false positives. We will have to log,

Re: [v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread 'Andreas Rossberg' via v8-users
Firefox simply got lucky in the case of the referenced bug, because some web pages serve different code depending on what browser they encounter. On 27 November 2014 at 13:14, Mathias Bynens mathi...@opera.com wrote: On Thu, Nov 27, 2014 at 1:06 PM, Philip Jägenstedt phil...@opera.com wrote:

Re: [v8-users] Re: [blink-dev] Intent to ship: ES6 String functions

2014-11-27 Thread PhistucK
Then I guess I am also looking to help educate about new platform features. I understand this use case is much less needed, though. ☆*PhistucK* On Thu, Nov 27, 2014 at 9:52 PM, Dmitry Lomov dslo...@chromium.org wrote: On Thu, Nov 27, 2014 at 8:48 PM, PhistucK phist...@gmail.com wrote: