Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Benedikt Meurer
LGTM Mathias Bynens schrieb am Fr., 9. Feb. 2018, 16:36: > Contact emails math...@chromium.org Spec > https://github.com/tc39/proposal-string-left-right-trim Summary Until > now, String.prototype.{trimLeft,trimRight} were non-standard language > extensions, required for

[v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Mathias Bynens
Contact emails math...@chromium.org Spec https://github.com/tc39/proposal-string-left-right-trim Summary Until now, String.prototype.{trimLeft,trimRight} were non-standard language extensions, required for Web compatibility. The Stage 3 proposal at

Re: [v8-users] --print-code does not work

2018-02-09 Thread Jakob Kummerow
If --print-opt-code prints nothing, then probably your function isn't getting optimized. Try calling it more often. --print-code is "technically correct" in the sense that it prints all of the unoptimized machine code that V8 doesn't generate any more ;-) (We should remove the flag.) On Fri,

Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Sathya Gunasekaran
LGTM On Fri, Feb 9, 2018 at 8:36 AM, Benedikt Meurer wrote: > LGTM > > > Mathias Bynens schrieb am Fr., 9. Feb. 2018, 16:36: > >> Contact emails math...@chromium.org Spec https://github.com/tc39/ >> proposal-string-left-right-trim Summary Until now,

Re: [v8-users] Intent to ship: String.prototype.trimStart / String.prototype.trimEnd

2018-02-09 Thread Adam Klein
LGTM3! On Fri, Feb 9, 2018 at 12:52 PM, Sathya Gunasekaran wrote: > LGTM > > On Fri, Feb 9, 2018 at 8:36 AM, Benedikt Meurer > wrote: > >> LGTM >> >> >> Mathias Bynens schrieb am Fr., 9. Feb. 2018, >> 16:36: >> >>> Contact

[v8-users] --print-code does not work

2018-02-09 Thread Istvan Tabanyi
Hi, I compiled v8 from sources successfully, but --print-code/--print-opt-code gives me no output at all. --print-bytecode works fine, --print-all-code prints something, but the actual code is definitely not in the output(Created a simple function with unique name, called in a loop, grepped