Re: [v8-users] Re: How incremental can incremental marking be?

2018-04-11 Thread 'Ulan Degenbaev' via v8-users
Thank you, John. This looks like an unfortunate interaction of V8 incremental marker with NodeJS's implementation of v8::Platform. The incremental marker posts a 1ms task that does a marking step and reposts itself (using v8::Platform::CallOnForegroundThread). This works well in Chrome, but in

Re: [v8-users] Re: How incremental can incremental marking be?

2018-04-11 Thread 'Ulan Degenbaev' via v8-users
I filed https://github.com/nodejs/node/issues/19937 On Wed, Apr 11, 2018 at 12:03 PM, Ulan Degenbaev wrote: > Thank you, John. > > This looks like an unfortunate interaction of V8 incremental marker with > NodeJS's implementation of v8::Platform. > > The incremental marker

Re: [v8-users] Re: How incremental can incremental marking be?

2018-04-11 Thread Hannes Payer
+Ulan Degenbaev On Wed, Apr 11, 2018 at 10:57 AM wrote: > Thanks John for your detailed report. > > You are right, incremental marking steps should ideally be spread out over > the whole program execution. It seems like the incremental marking task is >

Re: [v8-users] ways to prevent scripts from accessing certain built-in features

2018-04-11 Thread YJ
Thanks Ben. Will give that a shot. I had experimented with interceptors but unfortunately I can't seem to return a normal global object from inside an global interceptor as accessing a property triggers that interceptor again. On Wednesday, April 11, 2018 at 5:13:37 PM UTC+8, Ben Noordhuis

[v8-users] How incremental can incremental marking be?

2018-04-11 Thread John Edwards
Hi all! Just want to lead with a quick thanks to everyone who makes v8 happen! It's been a super useful piece of technology for me for many years. That said, it can still be quite mysterious, and, most recently, I've been trying to understand a bit more about the incremental marking part of the

[v8-users] Re: How incremental can incremental marking be?

2018-04-11 Thread hpayer
Thanks John for your detailed report. You are right, incremental marking steps should ideally be spread out over the whole program execution. It seems like the incremental marking task is the only task running in the observed trace. Do you have any JavaScript work pending? JavaScript should

Re: [v8-users] ways to prevent scripts from accessing certain built-in features

2018-04-11 Thread Ben Noordhuis
On Wed, Apr 11, 2018 at 6:58 AM, YJ wrote: > Hi v8-users, > > In certain situations we want user scripts to run in a context where the > scripts don't get to use some of the newer ECMAScript features, for > instance, Atomics, typed arrays etc. What is the recommended way to

Re: [v8-users] Re: How incremental can incremental marking be?

2018-04-11 Thread John Edwards
Thanks for the quick responses. Glad to see it's being taken care of in node! On Wednesday, April 11, 2018 at 3:13:54 AM UTC-7, Ulan Degenbaev wrote: > > I filed https://github.com/nodejs/node/issues/19937 > > On Wed, Apr 11, 2018 at 12:03 PM, Ulan Degenbaev wrote: > >> Thank