Re: [v8-users] info.This().GetAlignedPointerFromInternalField() crashes in property callbacks when applied to global object?

2017-04-20 Thread 'Kenton Varda' via v8-users
Hi Toon, Now I have a new problem: When I attach an ArgumentSignature to my property, it fails when accessing the property on the global object (both with and without "this."). Signatures on methods seem to work fine, though, even when calling on the global object. Is there a special-case that

Re: [v8-users] info.This().GetAlignedPointerFromInternalField() crashes in property callbacks when applied to global object?

2017-04-20 Thread 'Kenton Varda' via v8-users
Oh I see, somehow I missed your CL link. Thanks! :) -Kenton On Thu, Apr 20, 2017 at 12:09 PM, Toon Verwaest wrote: > That's exactly why I'm fixing the problem :-) The fix was temporarily > reverted since there are tests in Blink for which the expectations change, > and

Re: [v8-users] info.This().GetAlignedPointerFromInternalField() crashes in property callbacks when applied to global object?

2017-04-20 Thread Toon Verwaest
That's exactly why I'm fixing the problem :-) The fix was temporarily reverted since there are tests in Blink for which the expectations change, and that takes a while to sync; but you can try with the CL I linked above. On Thu, Apr 20, 2017 at 6:40 PM 'Kenton Varda' via v8-users <

Re: [v8-users] info.This().GetAlignedPointerFromInternalField() crashes in property callbacks when applied to global object?

2017-04-20 Thread 'Kenton Varda' via v8-users
Thanks, but what if I don't control the scripts and can't force them to prefix global property access with "this."? -Kenton On Thu, Apr 20, 2017 at 1:39 AM, Toon Verwaest wrote: > The problem is that since you're accessing the global property via > 'contextual access',

Re: [v8-users] info.This().GetAlignedPointerFromInternalField() crashes in property callbacks when applied to global object?

2017-04-20 Thread Toon Verwaest
The problem is that since you're accessing the global property via 'contextual access', we're passing out the global object rather than the global proxy (see https://developer.mozilla.org/en-US/docs/Mozilla/Projects/SpiderMonkey/Split_object for background). If you replace v8::Local source =