Re: [Valgrind-developers] Some changes and additional tests for helgrind.

2008-01-18 Thread Konstantin Serebryany
>> Anyway, I'll try the 64-bit patch I've tried both helgrinds (original one with 32-bit SVals and the one with 64-bit SVals). The test program natively works about 4 seconds. 'top' output (sampled each 5 seconds and took the largest one). 32bit SVal: PID USER PR NI VIRT RES SHR S %CPU

Re: [Valgrind-developers] Some changes and additional tests for helgrind.

2008-01-16 Thread Konstantin Serebryany
Great! Do you plan to checkin these or similar changes in future? Maybe under #ifdef so that users do not suffer if they don't need too many [TL]SETs? While I think that something like 24 bits for [TL]SETs is a must for large apps, it might not be enough. We may need some garbage collection for [T

Re: [Valgrind-developers] Some changes and additional tests for helgrind.

2008-01-15 Thread Julian Seward
> [...] change SVal to 64-bit at some point (I vote for it!), I already did that in Nov 07, but did not commit due to increase in run time and space usage. The resulting patch is attached. It allows up to 24 bits for lock- and thread-set IDs. I can't remember now why I limited it to 24 bits --