Re: [Valgrind-developers] syswrap for sync_file_range()

2008-01-08 Thread Tom Hughes
In message <[EMAIL PROTECTED]> Russell Sears <[EMAIL PROTECTED]> wrote: >> The wrapper should probably also validate the file descriptor like >> other wrappers which have file descriptor arguments do. > > I couldn't find any wrappers that do anything special with their file > descriptor ar

Re: [Valgrind-developers] syswrap for sync_file_range()

2008-01-07 Thread Russell Sears
Tom Hughes wrote: On 03/01/2008, Nicholas Nethercote <[EMAIL PROTECTED]> wrote: If a kernel type isn't present, a vki_* version should be added. See the comment at the top of include/vki/vki-linux.h. But don't trust the man pages, they mostly describe glibc's wrappers for the syscalls. These

Re: [Valgrind-developers] syswrap for sync_file_range()

2008-01-03 Thread Tom Hughes
On 03/01/2008, Nicholas Nethercote <[EMAIL PROTECTED]> wrote: > If a kernel type isn't present, a vki_* version should be added. > See the comment at the top of include/vki/vki-linux.h. > > But don't trust the man pages, they mostly describe glibc's wrappers for the > syscalls. These mostly are t

Re: [Valgrind-developers] syswrap for sync_file_range()

2008-01-03 Thread Nicholas Nethercote
On Thu, 3 Jan 2008, Russell Sears wrote: > I've attached a patch that adds support for Linux's sync_file_range. I > tested it under x86_64, and added an entry for x86 since I happened to find > the syscall number in my /usr/include directory. Presumably, it's supported > on other architecture

[Valgrind-developers] syswrap for sync_file_range()

2008-01-03 Thread Russell Sears
I've attached a patch that adds support for Linux's sync_file_range. I tested it under x86_64, and added an entry for x86 since I happened to find the syscall number in my /usr/include directory. Presumably, it's supported on other architectures too... The manpage lists "off64_t" as the type