> I'm wondering what is the right thing to do here. Having the format string
> warnings is nice, but we should be consistent. Eg. when printing pointers,
> should we use %p and cast to (void*) when necessary, instead of using
> 0x%lx?
In the long run fixing the format strings to keep gcc happy
On 10/3/07, Julian Seward <[EMAIL PROTECTED]> wrote:
>
>
> > I'm wondering what is the right thing to do here. Having the format
> string
> > warnings is nice, but we should be consistent. Eg. when printing
> pointers,
> > should we use %p and cast to (void*) when necessary, instead of using
> >
> I agree with the concerns raised above. But regarding (3): how about the
> warnings gcc emits on format strings like "%,d", which are supported by
> Valgrind but which are not allowed by ANSI C ?
I wondered about that too, but at least using gcc 4.1.2 I got no complaints
about "%,d". So it see
On 10/3/07, Julian Seward <[EMAIL PROTECTED]> wrote:
>
>
> > I agree with the concerns raised above. But regarding (3): how about the
> > warnings gcc emits on format strings like "%,d", which are supported by
> > Valgrind but which are not allowed by ANSI C ?
>
> I wondered about that too, but at
Nightly build on minnie ( SuSE 10.0, ppc32 ) started at 2007-10-03 09:00:02 BST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ..
Author: sewardj
Date: 2007-10-03 21:18:28 +0100 (Wed, 03 Oct 2007)
New Revision: 6932
Log:
Rewrite the lock order acquisition tracking machinery so it's (more
likely to be) correct. Unfortunately the performance is now very
poor.
Modified:
branches/THRCHECK/thrcheck/tc_main.c
Modified: bran
Author: sewardj
Date: 2007-10-03 21:34:03 +0100 (Wed, 03 Oct 2007)
New Revision: 6933
Log:
More regression tests.
Added:
branches/THRCHECK/thrcheck/tests/tc11_XCHG.vgtest
branches/THRCHECK/thrcheck/tests/tc12_rwl_trivial.c
branches/THRCHECK/thrcheck/tests/tc12_rwl_trivial.stderr.exp
b
Author: sewardj
Date: 2007-10-03 22:09:17 +0100 (Wed, 03 Oct 2007)
New Revision: 6934
Log:
Improve anonymisation of regtest outputs, and update expected outputs.
Modified:
branches/THRCHECK/thrcheck/tests/filter_stderr
branches/THRCHECK/thrcheck/tests/hg02_deadlock.stderr.exp
branches/TH
On Wed, 3 Oct 2007, Bart Van Assche wrote:
> The trend with gcc is that new versions move closer to the ANSI standard.
> Since the comma is not a valid flag character in ANSI C, we can expect that
> a future gcc version will complain about it. Do you think it would be a good
> idea to modify the V
On Mon, 1 Oct 2007, Shahriyar Amini wrote:
> I am in the process of porting a tool that was written in Valgrind 2.2.0
> to Valgrind 3.3.0. I have attained my copy of the source code from svn.
> I was wondering if there is a quick and easy way to save the work under :
>
> UCodeBlock* SK_(instrument
Nightly build on g5 ( SuSE 10.1, ppc970 ) started at 2007-10-04 02:00:01 CEST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ...
Author: sewardj
Date: 2007-10-04 01:26:24 +0100 (Thu, 04 Oct 2007)
New Revision: 6935
Log:
Rewrite the LAOG machinery for a third time, using a redundant
bidirectional graph implementation based on WordFM and WordSet. This
largely but not completely fixes the performance problems introduced
by r6
Nightly build on gill ( x86_64, Fedora Core 2 ) started at 2007-10-04 03:00:03
BST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests
Nightly build on lloyd ( x86_64, Fedora 7 ) started at 2007-10-04 03:05:05 BST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ...
Nightly build on dellow ( x86_64, Fedora 7 ) started at 2007-10-04 03:10:07 BST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ..
Nightly build on alvis ( i686, Red Hat 7.3 ) started at 2007-10-04 03:15:01 BST
Results unchanged from 24 hours ago
Checking out valgrind source tree ... done
Configuring valgrind ... done
Building valgrind ... done
Running regression tests ..
Author: njn
Date: 2007-10-04 06:28:54 +0100 (Thu, 04 Oct 2007)
New Revision: 6936
Log:
comment
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2/massif/ms_main.c 2
Author: njn
Date: 2007-10-04 06:32:17 +0100 (Thu, 04 Oct 2007)
New Revision: 6937
Log:
parameterise VERB
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2/massif/ms_
Author: njn
Date: 2007-10-04 06:34:56 +0100 (Thu, 04 Oct 2007)
New Revision: 6938
Log:
minor VERB changes
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2/massif/ms
Author: njn
Date: 2007-10-04 06:45:01 +0100 (Thu, 04 Oct 2007)
New Revision: 6939
Log:
Various comment, formatting, etc, changes. No functional changes.
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
==
Author: njn
Date: 2007-10-04 06:51:24 +0100 (Thu, 04 Oct 2007)
New Revision: 6940
Log:
Minor changes.
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2/massif/ms_mai
Author: njn
Date: 2007-10-04 07:13:37 +0100 (Thu, 04 Oct 2007)
New Revision: 6942
Log:
Add some more verbosity output.
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASS
Author: njn
Date: 2007-10-04 07:18:25 +0100 (Thu, 04 Oct 2007)
New Revision: 6943
Log:
this should have gone in the last commit
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- bran
Author: njn
Date: 2007-10-04 07:02:41 +0100 (Thu, 04 Oct 2007)
New Revision: 6941
Log:
factor stats taking a little
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2
Author: njn
Date: 2007-10-04 07:38:28 +0100 (Thu, 04 Oct 2007)
New Revision: 6944
Log:
- don't do stack snapshots until we've started executing code, to avoid the
strange start-up SP updates
- other minor changes
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif
Author: njn
Date: 2007-10-04 07:43:42 +0100 (Thu, 04 Oct 2007)
New Revision: 6945
Log:
comment wibble
Modified:
branches/MASSIF2/massif/ms_main.c
Modified: branches/MASSIF2/massif/ms_main.c
===
--- branches/MASSIF2/massif/ms_mai
26 matches
Mail list logo