Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-16 Thread David Holmes
Specdiffs now available again: http://cr.openjdk.java.net/~dholmes/8010319/specs/java.lang/java/lang/Class.html http://cr.openjdk.java.net/~dholmes/8010319/specs/java.lang.invoke/java/lang/invoke/MethodHandle.html

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-16 Thread David Holmes
Hi Karen, On 16/02/2018 8:01 AM, Karen Kinnear wrote: David, I think that is a much better solution. Let the description of each Lookup mode be precise, and you have already updated PRIVATE mode to include nestmates. Okay I've deleted that sentence. Unfortunately something has broken

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-15 Thread Karen Kinnear
David, I think that is a much better solution. Let the description of each Lookup mode be precise, and you have already updated PRIVATE mode to include nestmates. I brought this concern up in the EG meeting yesterday and wanted to clarify the difference between handling of inner/outer classes

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-14 Thread David Holmes
Hi Karen, Thanks for looking at this. On 15/02/2018 1:16 AM, Karen Kinnear wrote: David, Re-reading these I had one suggestion: - java/lang/invoke/MethodHandles.java * - * In some cases, access between nested classes is obtained by the Java compiler by creating - * an

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-13 Thread Paul Sandoz
> On Feb 12, 2018, at 6:51 PM, David Holmes wrote: >>> But I, for one, prefer a "user pays" scheme over an "everyone pays" scheme >>> (which is what disallowing duplicates would also be). >> It’s an awkward situation, experience suggests this type of thing bites back

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-12 Thread David Holmes
On 13/02/2018 12:51 PM, David Holmes wrote: On 13/02/2018 12:39 PM, Paul Sandoz wrote: On Feb 12, 2018, at 6:24 PM, David Holmes wrote: On 13/02/2018 11:45 AM, Paul Sandoz wrote: On Feb 12, 2018, at 1:55 PM, David Holmes wrote:

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-02-12 Thread Paul Sandoz
> On Feb 11, 2018, at 5:19 PM, David Holmes wrote: > > Hi Paul, > > On 1/02/2018 2:48 AM, Paul Sandoz wrote: >>> On Jan 30, 2018, at 7:22 PM, David Holmes wrote: >>> On 31/01/2018 12:24 PM, Paul Sandoz wrote: > On Jan 30, 2018, at 1:55

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-01-31 Thread Paul Sandoz
> On Jan 30, 2018, at 7:22 PM, David Holmes wrote: > > Hi Paul, > > On 31/01/2018 12:24 PM, Paul Sandoz wrote: >>> On Jan 30, 2018, at 1:55 AM, David Holmes >> > wrote: >>> >>> >>> MethodHandle API

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-01-30 Thread David Holmes
Hi Paul, On 31/01/2018 12:24 PM, Paul Sandoz wrote: On Jan 30, 2018, at 1:55 AM, David Holmes > wrote: MethodHandle API Changes: - java/lang/invoke/MethodHandle.java * A non-virtual method handle to a specific virtual method

Re: API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-01-30 Thread Daniel Heidinga
Thanks David.   These changes all seem reasonable.  I was going to complain about changing 'will occur' to 'may occur' as 'may' make makes it difficult to determine when it will vs won't occur but I think it's correct in this case.   --Dan   - Original message -From: David Holmes

API Updates: 8191116: [Nestmates] Update core reflection, MethodHandle and varhandle APIs to allow for nestmate access

2018-01-30 Thread David Holmes
I've gone through the API specifications for core reflection, MethodHandles and VarHandles to see what changes are needed to accommodate nestmates and the related invocation rule changes. Turns out there is very little needed and most of what there is is non-normative, just correcting or