Re: [master] a4e07fc Correct this test for good

2017-01-28 Thread Dridi Boukelmoune 
> As for the solution to this particular problem, I find it quite
> elegant naming aside.

Except that it fails on FreeBSD and SunOS, I'm pushing a revert :(

Dridi

___
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev

Re: [master] a4e07fc Correct this test for good

2017-01-28 Thread Dridi Boukelmoune 
On Sat, Jan 28, 2017 at 7:03 PM, Federico G. Schwindt  wrote:
>
> commit a4e07fc5a611062afddd2fb114d43d793054c15f
> Author: Federico G. Schwindt 
> Date:   Sat Jan 28 14:38:50 2017 +
>
> Correct this test for good
>
> (Ab)use the bound address used for the bad_backend macro to expose a
> random port and avoid the dreaded collisions.

This is a topic I actually wanted to bring up to the next bugwash (I
couldn't attend last Monday) and while ${bad_backend} is convenient
for testing, it relies on brittle behavior from the way varnish does
host/port resolution. It doesn't question tests relying on this macro
and the new ${random_port}. I found both names misleading too.

As for the solution to this particular problem, I find it quite
elegant naming aside.

Dridi

___
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev