Re: autocrap de-cargo-culting

2016-11-26 Thread Dridi Boukelmoune
> That's high on my list of things we don't need to worry about and
> consequently doesn't have to test :-)
>
> Feel free to de-cargo-cult as you see fit & when you see fit...

I gave a quick try to libraries detection [1] and I was wondering why
we bother with platform detection. For instance, do we care what
platform have libumem or jemalloc today? If we don't care, then
detection will fail just fine today and start working [2] as soon as
the libraries hypothetically appear on other Varnish-supported
platforms.

Dridi

[1] https://github.com/varnishcache/varnish-cache/commit/d6216cc
[2] to some uncertain degree of working

___
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev


Re: autocrap de-cargo-culting

2016-11-25 Thread Poul-Henning Kamp

In message 

Re: autocrap de-cargo-culting

2016-11-25 Thread Dridi Boukelmoune
On Fri, Nov 25, 2016 at 11:32 AM, Poul-Henning Kamp  wrote:
> Does anybody know of any reason not to apply this patch ?

When I asked whether I could sweep through the build system, it was
partly to get rid of the accumulated cruft. But this being Varnish,
I'd take a more conservative approach :)

Short answer is, no, you can't safely apply this patch. It depends on
what you'd consider safe.

Dridi

___
varnish-dev mailing list
varnish-dev@varnish-cache.org
https://www.varnish-cache.org/lists/mailman/listinfo/varnish-dev